From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8510 invoked by alias); 2 Jan 2015 11:22:41 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 34074 Received: (qmail 26343 invoked from network); 2 Jan 2015 11:22:23 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 From: Frank Terbeck To: Marc Finet Cc: zsh-workers@zsh.org Subject: Re: [PATCH 6/9] vcs_info quilt: fix unapplied detection on sub-directory In-Reply-To: <20141111100752.GA8974@mlap.lactee> (Marc Finet's message of "Tue, 11 Nov 2014 11:07:52 +0100") References: <1410557443-24178-1-git-send-email-m.dreadlock@gmail.com> <1410557443-24178-7-git-send-email-m.dreadlock@gmail.com> <87lhpm7ctw.fsf@ft.bewatermyfriend.org> <20141009003619.00001016@mlap.lactee> <8761ft44db.fsf@ft.bewatermyfriend.org> <20141016065926.3a4d503b@mlap.lactee> <87lhogctsb.fsf@ft.bewatermyfriend.org> <20141111100752.GA8974@mlap.lactee> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.51 (gnu/linux) Date: Fri, 02 Jan 2015 12:03:24 +0100 Message-ID: <871tndigw3.fsf@ft.bewatermyfriend.org> MIME-Version: 1.0 Content-Type: text/plain X-Df-Sender: NDMwNDQ0 Marc Finet wrote: > Sorry for lack of reactivity ;|. Sorry about that. I've been a fair bit busy the last months, getting my masters thesis out the door and starting a new job. I'm slowly trying to catch up with my backlog now. > On Thu, Oct 16, 2014 at 10:17:56AM +0200, Frank Terbeck wrote: >> Marc Finet wrote: [...] >> > So applied and unapplied lists are considered differents. The >> > .pc/applied-patches file contains only relative paths. >> >> I see. That could be fixed, I guess. Either by making the unapplied list >> absolute, or by trimming off the "repository's" root-directory from the >> absolute paths before comparing. > I do not see the point of specifying an absolute path for > QUILT_PATCHES (or quilt-patch-dir) since relative path work with quilt > (it automatically looks for upper directories if needed). Worse, > specifying absolute path in QUILT_PATCHES makes quilt unable to create > the .pc in the root since there is no root to deduce; on relative path, > root is the path where the QUILT_PATCHES path is found. Anyway, the > following patch fixes all the cases, i.e. specifying path (both absolute > or "relative") in QUILT_PATCHES or quilt-patch-dir. My idea about absolute directory names with $QUILT_PATCHES was to keep the patch directories in a separate place that was unrelated to the location of the source code. I guess you're running with this patch enabled now, right? If this current version works for you, I'd like to push it to the central repository now. Regards, Frank