zsh-workers
 help / color / mirror / code / Atom feed
From: Frank Terbeck <ft@bewatermyfriend.org>
To: Nikolai Weibull <now@bitwi.se>
Cc: zsh-workers@zsh.org
Subject: Re: PATCH: _git: Completion for `notes' sub-command
Date: Sat, 13 Feb 2010 12:56:45 +0100	[thread overview]
Message-ID: <871vgpz6v6.fsf@ft.bewatermyfriend.org> (raw)
In-Reply-To: <dbfc82861002130320m47af83a6gb1e351359f632655@mail.gmail.com> (Nikolai Weibull's message of "Sat, 13 Feb 2010 12:20:46 +0100")

Nikolai Weibull wrote:
> 2010/2/13 Frank Terbeck <ft@bewatermyfriend.org>:
>> +    show:"shot commit note"

Oops, indeed. Thanks.

While we're at it; _git's `#compdef' line is ridiculously long.
`git send-email' warns about a line longer than 998 characters, which
seems to be a limit in SMTP described in
<http://www.ietf.org/rfc/rfc2821.txt>.

Since git 1.6.0 you're not supposed to use `git-xxx' anymore, but to
use `git xxx'. And recently, git 1.7.0 was released, so I think it's
save to remove all those explicit comdefs.

I'll trim the `#compdef line down, unless people object - soon.

Regards, Frank

-- 
In protocol design, perfection has been reached not when there is
nothing left to add, but when there is nothing left to take away.
                                                  -- RFC 1925


  reply	other threads:[~2010-02-13 11:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-13 11:01 Frank Terbeck
2010-02-13 11:20 ` Nikolai Weibull
2010-02-13 11:56   ` Frank Terbeck [this message]
2010-02-13 12:39     ` Frank Terbeck
2010-02-13 12:43       ` Frank Terbeck
2010-02-14 15:30     ` Nikolai Weibull

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871vgpz6v6.fsf@ft.bewatermyfriend.org \
    --to=ft@bewatermyfriend.org \
    --cc=now@bitwi.se \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).