From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15532 invoked by alias); 13 Feb 2010 11:56:52 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 27704 Received: (qmail 16429 invoked from network); 13 Feb 2010 11:56:50 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.2.5 Received-SPF: none (ns1.primenet.com.au: domain at bewatermyfriend.org does not designate permitted sender hosts) From: Frank Terbeck To: Nikolai Weibull Cc: zsh-workers@zsh.org Subject: Re: PATCH: _git: Completion for `notes' sub-command In-Reply-To: (Nikolai Weibull's message of "Sat, 13 Feb 2010 12:20:46 +0100") References: <1266058879-14486-1-git-send-email-ft@bewatermyfriend.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) Date: Sat, 13 Feb 2010 12:56:45 +0100 Message-ID: <871vgpz6v6.fsf@ft.bewatermyfriend.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Df-Sender: 430444 Nikolai Weibull wrote: > 2010/2/13 Frank Terbeck : >> + =C2=A0 =C2=A0show:"shot commit note" Oops, indeed. Thanks. While we're at it; _git's `#compdef' line is ridiculously long. `git send-email' warns about a line longer than 998 characters, which seems to be a limit in SMTP described in . Since git 1.6.0 you're not supposed to use `git-xxx' anymore, but to use `git xxx'. And recently, git 1.7.0 was released, so I think it's save to remove all those explicit comdefs. I'll trim the `#compdef line down, unless people object - soon. Regards, Frank --=20 In protocol design, perfection has been reached not when there is nothing left to add, but when there is nothing left to take away. -- RFC 1925