zsh-workers
 help / color / mirror / code / Atom feed
From: Frank Terbeck <ft@bewatermyfriend.org>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-workers@zsh.org
Subject: Re: precmd: write error: interrupted
Date: Sun, 05 May 2013 02:01:33 +0200	[thread overview]
Message-ID: <8738u2b8gy.fsf@ft.bewatermyfriend.org> (raw)
In-Reply-To: <130428180338.ZM14577@torch.brasslantern.com> (Bart Schaefer's message of "Sun, 28 Apr 2013 18:03:38 -0700")

Hi Bart,

Bart Schaefer wrote:
[...]
> Here's a stab at a more comprehensive patch.  This follows the pattern of
> child_block()/child_unblock() which we use elsewhere to reap children only
> when safe to do so.
>
> I'm not 100% confident that this does the right thing for non-interactive
> shells/sourcing of scripts, but I *think* the change in shingetline()
> should cover those cases.

I'm afraid these changes break SIGWINCH handling of child processes.

If you start an editor or mail-reader or terminal-multiplexer (or
whatever really), that child will not react to any terminal-resizes
anymore.

It took a while to find out, why this:

  TRAPWINCH() { print $COLUMNS $LINES; }

didn't trigger in shells inside the terminal-multiplexer I use, but does
trigger in a naked xterm without multiplexer. The fact that the terminal
multiplexer itself didn't react to SIGWINCHes anymore steered me into
zsh's direction (well, not directly but eventually).

Building a version of the shell before these changes¹ makes everything
work again.  Sorry to be the bearer of bad news. ;)


Regards, Frank

¹ * cbf6f14 <Jun T> 31357: _cp: add support for Mac OS X (5 days ago)


  parent reply	other threads:[~2013-05-05  0:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <klbmnc$ieh$1@ger.gmane.org>
     [not found] ` <130425111646.ZM17258@torch.brasslantern.com>
     [not found]   ` <klc0n1$34u$1@ger.gmane.org>
2013-04-26  0:53     ` Bart Schaefer
     [not found]   ` <20130425193817.2f82b60c@pws-pc.ntlworld.com>
     [not found]     ` <130425151839.ZM17476@torch.brasslantern.com>
2013-04-26  8:42       ` Peter Stephenson
     [not found]   ` <klc2ah$jiv$1@ger.gmane.org>
     [not found]     ` <130426080805.ZM18619__18102.73175729$1366989065$gmane$org@torch.brasslantern.com>
2013-04-26 17:59       ` Yuri D'Elia
     [not found]     ` <130426080805.ZM18619@torch.brasslantern.com>
     [not found]       ` <517C0E09.4040505@users.sourceforge.net>
2013-04-27 22:31         ` Bart Schaefer
2013-04-28 15:30           ` Yuri D'Elia
2013-04-29  1:03             ` Bart Schaefer
2013-04-29  1:59               ` Bart Schaefer
2013-05-05  0:01               ` Frank Terbeck [this message]
2013-05-05  6:52                 ` Bart Schaefer
2013-05-05  9:38                   ` Frank Terbeck
2013-05-05 17:53                     ` Bart Schaefer
2013-05-05 18:37                       ` Frank Terbeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8738u2b8gy.fsf@ft.bewatermyfriend.org \
    --to=ft@bewatermyfriend.org \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).