From: Philippe Troin <phil@fifi.org>
To: Nicolas George <nicolas.george@ens.fr>
Cc: zsh-workers@sunsite.dk
Subject: Re: Subshell exiting, suspend problem
Date: 26 Sep 2003 11:32:43 -0700 [thread overview]
Message-ID: <873cejqu2c.fsf@ceramic.fifi.org> (raw)
In-Reply-To: <20030926165251.GA14940@clipper.ens.fr>
Nicolas George <nicolas.george@ens.fr> writes:
> There seems to be a problem with zsh process group handling: when zsh is
> invoked as an interactive subshell from a curses-based program (by
> example with :shell from vim, but the same is true with mutt, less,
> flrn...), when zsh exits, the calling process gets suspended for "tty
> output" (only if it is under job control, or else it makes a read
> error).
True indeed.
> The problem arises with zsh 4.1.1, or with a CVS snapshot from half an
> hour ago, and also with the Debian-patched 4.0.7.
>
> I have tracked the problem, and it seems that acquire_pgrp() is called
> from init_io(), but release_pgrp() is never called. The following patch
> fixes the problem:
>
>
> --- Src/builtin.c 2003-09-26 16:16:45.000000000 +0200
> +++ Src/builtin.c.orig 2003-09-26 16:16:09.000000000 +0200
> @@ -3977,9 +3977,6 @@
> if (sigtrapped[SIGEXIT])
> dotrap(SIGEXIT);
> runhookdef(EXITHOOK, NULL);
> - if (opts[MONITOR] && interact && (SHTTY != -1)) {
> - release_pgrp();
> - }
> if (mypid != getpid())
> _exit(val);
> else
Your patch seems to be reversed.
> But I am not quite sure if this is exactly the right thing: maybe the
> correct condition is to call release_pgrp() if and only if
> acquire_pgrp() was called. The only thing I am sure is that something
> like that is necessary.
No, you're right, release_pgrp() ought to be called upon exit. Good
catch.
I am going to run some extra tests before confirming this patch. I'm
also not sure we need all the extra tests (opts[MONITOR], etc).
Phil.
next prev parent reply other threads:[~2003-09-26 18:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-26 16:52 Nicolas George
2003-09-26 17:38 ` Bart Schaefer
2003-09-27 3:21 ` Philippe Troin
2003-09-27 21:00 ` Bart Schaefer
2003-09-26 18:32 ` Philippe Troin [this message]
2003-10-03 20:58 ` [19140] " Danek Duvall
2003-10-03 22:06 ` Philippe Troin
2003-10-03 22:24 ` Danek Duvall
2003-10-08 7:04 ` Danek Duvall
2003-10-08 7:26 ` Philippe Troin
2003-10-17 16:54 ` Philippe Troin
2003-10-21 7:30 ` Danek Duvall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=873cejqu2c.fsf@ceramic.fifi.org \
--to=phil@fifi.org \
--cc=nicolas.george@ens.fr \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).