test-repo-git-rebase-apply still in use?

test-repo-git-rebase-apply still in use?

[Jörg Sommer]

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

Hi,

is Functions/VCS_Info/test-repo-git-rebase-apply used anywhere? My git-grep
doesn't find any reference.

This file contains a hard-coded path for zsh (in the #!) which doesn't work
if it's installed somewhere else.

And is it useful to have this file on a common installation or should it get
excluded?

Regards Jörg

-- 
Geld allein macht nicht glücklich, aber es ist besser in einem Taxi zu
weinen, als in der Straßenbahn.
                                                (Marcel Reich‐Ranicki)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: test-repo-git-rebase-apply still in use?

[Daniel Shahaf]

Jörg Sommer wrote on Fri, 23 Aug 2024 06:59 +00:00:
> is Functions/VCS_Info/test-repo-git-rebase-apply used anywhere? My git-grep
> doesn't find any reference.

It's essentially a setup function for a manual test suite.  It's not user-facing,
but a developer might invoke it manually to test a patch being worked on.

> This file contains a hard-coded path for zsh (in the #!) which doesn't work
> if it's installed somewhere else.

That path doesn't exist on my system either.  Having it still helps
$EDITOR default to the right syntax highlighting, though.

I suppose it could be changed to use /usr/bin/env, or even /bin/sh but
for the use of ${foo:P} on line 47.

> And is it useful to have this file on a common installation or should it get
> excluded?

The latter.  And is there any way to make the script's purpose clearer?

Cheers,

Daniel