From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24371 invoked by alias); 5 Feb 2014 13:56:45 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 32351 Received: (qmail 29778 invoked from network); 5 Feb 2014 13:56:40 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 From: Greg Klanderman To: zsh-workers@zsh.org Subject: Re: Tests of interrupting completion, and completion_nostat_dirs Reply-to: gak@klanderman.net Date: Wed, 05 Feb 2014 08:56:31 -0500 In-reply-to: <140204212859.ZM21837@torch.brasslantern.com> (Bart Schaefer's message of "Tue, 04 Feb 2014 21:28:59 -0800") Message-id: <874n4dpss0.fsf@lwm.klanderman.net> User-Agent: Gnus/5.1008 (Gnus v5.10.8) XEmacs/21.4.22 (linux) References: <140122000435.ZM1516@torch.brasslantern.com> <140123171659.ZM19422@torch.brasslantern.com> <87iot91lp8.fsf@lwm.klanderman.net> <140125124934.ZM23767@torch.brasslantern.com> <87eh3q3g63.fsf@lwm.klanderman.net> <140129181206.ZM22813@torch.brasslantern.com> <20140130093057.6e04fa53@pwslap01u.europe.root.pri> <140130082206.ZM23682@torch.brasslantern.com> <874n4g1blj.fsf@lwm.klanderman.net> <140204212859.ZM21837@torch.brasslantern.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii >>>>> On February 5, 2014 Bart Schaefer wrote: > Greg, I'm going to let Peter make the call on this one because he has > become more concerned about namespace clutter that I. > I would say that the change to ztat() should continue to read from a > variable. I think I'd have ztat() call getaparam() rather than declare > a C array tied to a special variable (compare the way zle_refresh.c > handles zle_highlight) but I'll stop at that. Thank you Bart, the only downside I see is that I currently use the existence of the special variable to decide whether to configure the automount points in the fake-files zstyle, since I end up having to kill my shell from another window if the automounts get configured in a shell that doesn't have my patch and I ever hit tab to complete under an automount. If I use getaparam, is the only way to test if the feature exists with a ZSH_VERSION / ZSH_PATCHLEVEL check? Do we have any mechanism for creating named features to test against? Would it make sense to add a readonly 'features' associative array (maybe in the zsh/parameter module) whose keys are feature strings? I'll wait to hear from Peter before doing anything.. Greg