From: Frank Terbeck <ft@bewatermyfriend.org>
To: Alexey Sokolov <sokolov@google.com>
Cc: zsh-workers@zsh.org
Subject: Re: Use HGPLAIN instead of HGRCPATH in VCS_INFO_get_data_hg
Date: Tue, 24 Oct 2017 23:39:37 +0200 [thread overview]
Message-ID: <8760b4tecm.fsf@ft.bewatermyfriend.org> (raw)
In-Reply-To: <CAL-Thktaa5NJBn4m1rqX-8yuWAO8VsMV8bZLJFcLSaB8e0SH2w@mail.gmail.com> (Alexey Sokolov's message of "Tue, 24 Oct 2017 19:14:01 +0100")
Hey Alexey,
Alexey Sokolov wrote:
> Use HGPLAIN instead of HGRCPATH in VCS_INFO_get_data_hg
>
> Fixes prompt indicator in case if the repository requires a non-default
> feature. With HGRCPATH, it results in:
>
> abort: repository requires features unknown to this Mercurial: ...
> (see https://mercurial-scm.org/wiki/MissingRequirement for more
> information)
>
> Which, in turn, results in "default" getting reported regardless of what
> the current state of the repo is.
Could you maybe resend the patch attached? You MUA seems to have mangled
it a tad. Preferably, commit locally, use "git format-patch -1" and send
the resulting file.
That makes attribution and integration as simple as possible for us.
Thanks for your help as well!
Regards, Frank
--
In protocol design, perfection has been reached not when there is
nothing left to add, but when there is nothing left to take away.
-- RFC 1925
next prev parent reply other threads:[~2017-10-24 23:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-24 18:14 Alexey Sokolov
2017-10-24 21:39 ` Frank Terbeck [this message]
2017-10-24 22:36 ` Alexey Sokolov
2017-10-25 8:37 ` Frank Terbeck
2017-10-25 8:47 ` Peter Stephenson
2017-10-25 8:58 ` Alexey Sokolov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760b4tecm.fsf@ft.bewatermyfriend.org \
--to=ft@bewatermyfriend.org \
--cc=sokolov@google.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).