From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15534 invoked by alias); 14 Sep 2014 10:11:15 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 33167 Received: (qmail 22564 invoked from network); 14 Sep 2014 10:11:14 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 From: Frank Terbeck To: Marc Finet Cc: zsh-workers@zsh.org Subject: Re: [PATCH 9/9] completion git: fix send-email --confirm values In-Reply-To: <1410557443-24178-10-git-send-email-m.dreadlock@gmail.com> (Marc Finet's message of "Fri, 12 Sep 2014 23:30:43 +0200") References: <1410557443-24178-1-git-send-email-m.dreadlock@gmail.com> <1410557443-24178-10-git-send-email-m.dreadlock@gmail.com> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.93 (gnu/linux) Date: Sun, 14 Sep 2014 12:11:29 +0200 Message-ID: <8761gq7bqm.fsf@ft.bewatermyfriend.org> MIME-Version: 1.0 Content-Type: text/plain X-Df-Sender: NDMwNDQ0 Marc Finet wrote: > - '--confirm[specify type of confirmation required before sending]: :__git_sendemail_confirm' \ > + '--confirm[specify type of confirmation required before sending]: :__git_sendemail_confirm_values' \ Yes, this one is correct again. I'll be pushing the following patches in a bit: [PATCH 1/9] vcs_info examples: fix typo [PATCH 2/9] completion git: support aliases when \n e [PATCH 3/9] vcs_info git: detect revert or cherry-pic [PATCH 5/9] vcs_info quilt: fix standalone detection [PATCH 7/9] vcs_info git: fix applied-string name [PATCH 9/9] completion git: fix send-email --confirm I will not push these for now: [PATCH 6/9] vcs_info quilt: fix unapplied detection o ...because I don't think this one is correct. See my reply to the individual mail. [PATCH 4/9] vcs_info git: set rrn before using it Basically correct, but it should be set even earlier. See the individual mail about this as well. [PATCH 8/9] vcs_info git: consider patches for rebase I'm not quite through this one yet. But I like the basic idea and so far I've not seen anything that seems obviously wrong. I just need some more time. Regards, Frank