Re: PATCH: Add `--enable-additional-fpath' configure option

[Frank Terbeck <ft@bewatermyfriend.org>]

Bart Schaefer wrote:
> On Apr 17,  3:49pm, Frank Terbeck wrote:
> } Comments?  I won't be committing this before I get ACKs. :)
>
> This looks OK #ifdef-wise; if it compiles both ways you probaby didn't
> break anything. :-)  I have a feeling that there's a more compact way to
> do it (#if in fewer places), but maybe that would be less clear to a
> reader of the code.

Heh. I did test it both ways. But I just gave it a spin with more than 2
additional directories and it broke (a little), because s/// != s///g
with sed. The following patch is needed on top of the old one. I'll be
committing this in the evening.


diff --git a/Src/zsh.mdd b/Src/zsh.mdd
index c420bcc..9f19b45 100644
--- a/Src/zsh.mdd
+++ b/Src/zsh.mdd
@@ -87,7 +87,7 @@ zshpaths.h: Makemod $(CONFIG_INCS)
 	  fi; \
 	fi
 	@if test x$(additionalfpath) != x; then \
-	  fpath_tmp="`echo $(additionalfpath) | sed -e 's:,:\", \":'`"; \
+	  fpath_tmp="`echo $(additionalfpath) | sed -e 's:,:\", \":g'`"; \
 	  echo "#define ADDITIONAL_FPATH { \"$$fpath_tmp\" }" >> zshpaths.h.tmp; \
 	fi
 	@if cmp -s zshpaths.h zshpaths.h.tmp; then \