zsh-workers
 help / color / mirror / code / Atom feed
From: Frank Terbeck <ft@bewatermyfriend.org>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-workers@zsh.org
Subject: Re: PATCH: vcs_info: Set NO_warn_create_global option
Date: Sun, 21 Feb 2010 22:34:18 +0100	[thread overview]
Message-ID: <87635q8e91.fsf@ft.bewatermyfriend.org> (raw)
In-Reply-To: <100221131740.ZM24810@torch.brasslantern.com> (Bart Schaefer's message of "Sun, 21 Feb 2010 13:17:40 -0800")

Bart Schaefer wrote:
> On Feb 21,  9:06pm, Frank Terbeck wrote:
[...]
> } Any ideas where to apply the leverage?
>
> In Src/params.c, assignsparam() and assignaparam(), I suppose, by a
> check of v->pm->node.nam against a list (which doesn't exist yet) of
> parameters that don't require warnings.  I further suppose that list
> could itself be controlled by a parameter, but that'd have to be
> handled carefully to avoid fetching a value while setting it.

Sounds reasonable, but is well beyond my expertise in zsh's code.

> I see PWS has already applied your (a) patch from 27731, so perhaps
> this discussion is moot ...

Yes I've seen it, too. But I'd like to have `warn_create_global' active
while vcs_info is running (without cutting off useful features such as
zstyle's "-e" option), if possible. It's code should run fine with the
option set. And having it set prevents me from becoming sloppy.

Regards, Frank

-- 
In protocol design, perfection has been reached not when there is
nothing left to add, but when there is nothing left to take away.
                                                  -- RFC 1925


      reply	other threads:[~2010-02-21 21:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-21 14:53 Frank Terbeck
2010-02-21 15:09 ` PATCH: Disable WARN_CREATE_GLOBAL in 'zstyle -e' code Frank Terbeck
2010-02-21 15:18   ` Frank Terbeck
2010-02-21 17:25 ` PATCH: vcs_info: Set NO_warn_create_global option Bart Schaefer
2010-02-21 20:06   ` Frank Terbeck
2010-02-21 21:17     ` Bart Schaefer
2010-02-21 21:34       ` Frank Terbeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87635q8e91.fsf@ft.bewatermyfriend.org \
    --to=ft@bewatermyfriend.org \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).