From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5969 invoked by alias); 21 Feb 2010 21:34:28 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 27742 Received: (qmail 26298 invoked from network); 21 Feb 2010 21:34:26 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.2.5 Received-SPF: none (ns1.primenet.com.au: domain at bewatermyfriend.org does not designate permitted sender hosts) From: Frank Terbeck To: Bart Schaefer Cc: zsh-workers@zsh.org Subject: Re: PATCH: vcs_info: Set NO_warn_create_global option In-Reply-To: <100221131740.ZM24810@torch.brasslantern.com> (Bart Schaefer's message of "Sun, 21 Feb 2010 13:17:40 -0800") References: <1266764004-15068-1-git-send-email-ft@bewatermyfriend.org> <100221092514.ZM24056@torch.brasslantern.com> <87d3zy8ib8.fsf@ft.bewatermyfriend.org> <100221131740.ZM24810@torch.brasslantern.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) Date: Sun, 21 Feb 2010 22:34:18 +0100 Message-ID: <87635q8e91.fsf@ft.bewatermyfriend.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Df-Sender: 430444 Bart Schaefer wrote: > On Feb 21, 9:06pm, Frank Terbeck wrote: [...] > } Any ideas where to apply the leverage? > > In Src/params.c, assignsparam() and assignaparam(), I suppose, by a > check of v->pm->node.nam against a list (which doesn't exist yet) of > parameters that don't require warnings. I further suppose that list > could itself be controlled by a parameter, but that'd have to be > handled carefully to avoid fetching a value while setting it. Sounds reasonable, but is well beyond my expertise in zsh's code. > I see PWS has already applied your (a) patch from 27731, so perhaps > this discussion is moot ... Yes I've seen it, too. But I'd like to have `warn_create_global' active while vcs_info is running (without cutting off useful features such as zstyle's "-e" option), if possible. It's code should run fine with the option set. And having it set prevents me from becoming sloppy. Regards, Frank -- In protocol design, perfection has been reached not when there is nothing left to add, but when there is nothing left to take away. -- RFC 1925