From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27331 invoked by alias); 13 Sep 2014 12:45:40 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 33157 Received: (qmail 8904 invoked from network); 13 Sep 2014 12:45:38 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 From: Frank Terbeck To: Marc Finet Cc: zsh-workers@zsh.org Subject: Re: Misc patches for git completion and vcs_info In-Reply-To: <1410557443-24178-1-git-send-email-m.dreadlock@gmail.com> (Marc Finet's message of "Fri, 12 Sep 2014 23:30:34 +0200") References: <1410557443-24178-1-git-send-email-m.dreadlock@gmail.com> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.93 (gnu/linux) Date: Sat, 13 Sep 2014 14:23:00 +0200 Message-ID: <877g1790bf.fsf@ft.bewatermyfriend.org> MIME-Version: 1.0 Content-Type: text/plain X-Df-Sender: NDMwNDQ0 Hey Marc, Marc Finet wrote: > Below is a list of patches that i added in my current zsh (based on > tonight's master). Please consider them for review as my zsh-level is > currently very low (e.g. patch 2) and i might have broken other use-cases > (patch 4 for instance makes me a little bit nervous as it seems to easy). I'll take a look at the vcs_info related ones as soon as I can; most look straightforward, though. I'm so far only unsure about the patches that touch the quilt backend (well, and the big one, 8/9, which I didn't look at, yet, at all). git-completion patches: The one about _confirm vs. _confirm_values is correct, since __git_sendemail_confirm() doesn't even exist. The one about the alias completion, is a bit more complex, obviously. I don't have multi-line aliases set in my git-configuration, so I'll take your word for it. :-) Regards, Frank