From: Frank Terbeck <ft@bewatermyfriend.org>
To: "Øystein Walle" <oystwa@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH 0/7] Various fixes to Git completion
Date: Mon, 21 Oct 2013 12:28:34 +0200 [thread overview]
Message-ID: <877gd6syst.fsf@ft.bewatermyfriend.org> (raw)
In-Reply-To: <cover.1382290245.git.oystwa@gmail.com> (=?utf-8?Q?=22=C3=98y?= =?utf-8?Q?stein?= Walle"'s message of "Sun, 20 Oct 2013 19:40:58 +0200")
Heya!
I looked at both your series:
Øystein Walle wrote:
[...]
> m0viefreak (3):
> _git: Remove unsupported -q option from diff options
> _git: fix a few "undocumented" options
> _git: revert: add '-e,--edit'
>
> Øystein Walle (4):
> _git: Add missing column.* config variables
> _git: Make git-show accept diff arguments
> _git: re-order the last two git-blame arguments
> _git: fix wrong default value
>
> Completion/Unix/Command/_git | 36 +++++++++++++++++++++++-------------
> 1 file changed, 23 insertions(+), 13 deletions(-)
[...]
> Øystein Walle (6):
> _git: Add git-clean -i/--interactive support
> _git: Add new arguments introduced in Git v1.8.4
> _git: Add status.short and status.branch
> _git: Reword --heads to match new meaning
> _git: Add two sub-comamnds introduced in v1.8.4
> _git: Make --batch(-check) accept an argument
>
> Completion/Unix/Command/_git | 42 ++++++++++++++++++++++++++++++++++++------
> 1 file changed, 36 insertions(+), 6 deletions(-)
I didn't find anything obviously wrong with those, so I'll import and
push them later today.
Thanks for your work, the both of you!
Regards, Frank
--
In protocol design, perfection has been reached not when there is
nothing left to add, but when there is nothing left to take away.
-- RFC 1925
prev parent reply other threads:[~2013-10-21 10:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-20 17:40 Øystein Walle
2013-10-20 17:40 ` [PATCH 1/7] _git: Add missing column.* config variables Øystein Walle
2013-10-20 17:41 ` [PATCH 2/7] _git: Make git-show accept diff arguments Øystein Walle
2015-05-08 14:46 ` [PATCH 1/2] completion: git: split diff options for stages (--theirs, --ours etc) Daniel Hahler
2015-05-08 14:46 ` [PATCH 2/2] completion: git: do not add diff options twice Daniel Hahler
2015-05-16 22:55 ` [PATCH 1/2] completion: git: split diff options for stages (--theirs, --ours etc) Daniel Shahaf
2013-10-20 17:41 ` [PATCH 3/7] _git: re-order the last two git-blame arguments Øystein Walle
2013-10-20 17:41 ` [PATCH 4/7] _git: Remove unsupported -q option from diff options Øystein Walle
2013-10-20 17:41 ` [PATCH 5/7] _git: fix wrong default value Øystein Walle
2013-10-20 17:41 ` [PATCH 6/7] _git: fix a few "undocumented" options Øystein Walle
2013-10-20 17:41 ` [PATCH 7/7] _git: revert: add '-e,--edit' Øystein Walle
2013-10-21 10:28 ` Frank Terbeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877gd6syst.fsf@ft.bewatermyfriend.org \
--to=ft@bewatermyfriend.org \
--cc=oystwa@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).