From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19392 invoked by alias); 21 Oct 2013 10:37:25 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 31867 Received: (qmail 30000 invoked from network); 21 Oct 2013 10:37:19 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 From: Frank Terbeck To: =?utf-8?Q?=C3=98ystein?= Walle Cc: zsh-workers@zsh.org Subject: Re: [PATCH 0/7] Various fixes to Git completion In-Reply-To: (=?utf-8?Q?=22=C3=98y?= =?utf-8?Q?stein?= Walle"'s message of "Sun, 20 Oct 2013 19:40:58 +0200") References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) Date: Mon, 21 Oct 2013 12:28:34 +0200 Message-ID: <877gd6syst.fsf@ft.bewatermyfriend.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Df-Sender: NDMwNDQ0 Heya! I looked at both your series: =C3=98ystein Walle wrote: [...] > m0viefreak (3): > _git: Remove unsupported -q option from diff options > _git: fix a few "undocumented" options > _git: revert: add '-e,--edit' > > =C3=98ystein Walle (4): > _git: Add missing column.* config variables > _git: Make git-show accept diff arguments > _git: re-order the last two git-blame arguments > _git: fix wrong default value > > Completion/Unix/Command/_git | 36 +++++++++++++++++++++++------------- > 1 file changed, 23 insertions(+), 13 deletions(-) [...] > =C3=98ystein Walle (6): > _git: Add git-clean -i/--interactive support > _git: Add new arguments introduced in Git v1.8.4 > _git: Add status.short and status.branch > _git: Reword --heads to match new meaning > _git: Add two sub-comamnds introduced in v1.8.4 > _git: Make --batch(-check) accept an argument > > Completion/Unix/Command/_git | 42 ++++++++++++++++++++++++++++++++++++--= ---- > 1 file changed, 36 insertions(+), 6 deletions(-) I didn't find anything obviously wrong with those, so I'll import and push them later today. Thanks for your work, the both of you! Regards, Frank --=20 In protocol design, perfection has been reached not when there is nothing left to add, but when there is nothing left to take away. -- RFC 1925