Re: PATCH: PATCH: Add `sourcetrace' option

[Frank Terbeck <ft@bewatermyfriend.org>]

Frank Terbeck writes:
[...]
> diff --git a/Src/init.c b/Src/init.c
> index 123e20e..c59d632 100644
> --- a/Src/init.c
> +++ b/Src/init.c
> @@ -1102,6 +1102,11 @@ source(char *s)
>  	return SOURCE_NOT_FOUND;
>      }
>  
> +    if (isset(SOURCETRACE)) {
> +	fprintf(stderr, "sourcetrace> \"%s\"\n", s);
> +	fflush(stderr);
> +    }
> +
>      /* save the current shell state */
>      fd        = SHIN;            /* store the shell input fd                  */
>      obshin    = bshin;          /* store file handle for buffered shell input */
[...]

Okay, this breaks menu selection for me...

I've got no idea what's going on. Needless to say, this patch is worth
nothing if it breaks other parts of the shell. The test suite seems to
pass just fine. But menu selection, as I said doesn't work anymore.

I'm really interested in why the code above blows up menu selection.
Anyone who knows what's going on, feel free to explain what the deal
is here.


Regards, Frank - puzzled.