From: Frank Terbeck <ft@bewatermyfriend.org>
To: Jasper Lievisse Adriaanse <jasper@openbsd.org>
Cc: zsh-workers@zsh.org
Subject: Re: More complete tmux support
Date: Thu, 17 Apr 2014 16:09:43 +0200 [thread overview]
Message-ID: <878ur4xd20.fsf@ft.bewatermyfriend.org> (raw)
In-Reply-To: <20140417134303.GP20937@mail.jasper.la> (Jasper Lievisse Adriaanse's message of "Thu, 17 Apr 2014 15:43:03 +0200")
Jasper Lievisse Adriaanse wrote:
> Hi,
Hey there!
> We've had this patch for a long time in OpenBSD ports, it's to complete tmux
> support.
Great! I've been meaning to take a look for missing and changed features
for ages... but. Laziness. :)
However, something seems wrong with the patch.
[...]
> Subject: [PATCH] Add more complete tmux support.
>
> by pea@openbsd.org
> ---
> Completion/Unix/Command/_tmux | 1491 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 1491 insertions(+)
[...]
> diff --git a/Completion/Unix/Command/_tmux b/Completion/Unix/Command/_tmux
[...]
> +# --- Sub-command functions ---
> +# These *must* be called _tmux-*(); The description generation relies on
> +# them being names that way. *No* other functions may match that pattern.
> +# Other utility functions should be named __tmux-*() (see below).
> +#
> +# Another thing, the description generation needs, is handling of
> +# $tmux_describe: If that parameter is non-empty, the sub-command function
> +# should only print a description of the sub-command it handles and return
> +# immidiately after doing so.
> +#
> +# To add support for a new sub-command, you only have to add a new
> +# _tmux-<foo>() function below (preferably alphabetically sorted), that
> +# behaves like described above; and add a alias->command pair in the
> +# _tmux_aliasmap associative array above (if the comand in fact has an
> +# alias). The rest should just work[tm].
[...]
I don't understand why this comment is added here.
[...]
> +function _tmux-send-prefix() {
> + [[ -n ${tmux_describe} ]] && print "Send the prefix key to a window" && return
> + local -a args
> + args=('-t[Choose a target pane]:panes:__tmux-panes')
> + _arguments ${args}
> +}
[...]
There are multiple pre-existing function added as well.
[...]
> +_tmux
> +#compdef tmux
> +
> +# tmux <http://tmux.sf.net> completion for zsh <http://zsh.sf.net>.
> +#
> +# Configuration:
> +#
And then here the file starts all over again?
Would be great, if you could take a look at what went wrong here and
resend.
Regards, Frank
--
In protocol design, perfection has been reached not when there is
nothing left to add, but when there is nothing left to take away.
-- RFC 1925
prev parent reply other threads:[~2014-04-17 14:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 13:43 Jasper Lievisse Adriaanse
2014-04-17 14:09 ` Frank Terbeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878ur4xd20.fsf@ft.bewatermyfriend.org \
--to=ft@bewatermyfriend.org \
--cc=jasper@openbsd.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).