zsh-workers
 help / color / mirror / code / Atom feed
From: Frank Terbeck <ft@bewatermyfriend.org>
To: Simon Ruderich <simon@ruderich.org>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] _git: fix gitk
Date: Mon, 25 Apr 2011 14:36:22 +0200	[thread overview]
Message-ID: <878vuymrsp.fsf@ft.bewatermyfriend.org> (raw)
In-Reply-To: <20110425122823.GA16924@ruderich.org> (Simon Ruderich's message of "Mon, 25 Apr 2011 14:28:23 +0200")

Simon Ruderich wrote:
> On Mon, Apr 25, 2011 at 01:49:48PM +0200, Frank Terbeck wrote:
>> Felipe Contreras wrote:
>>> On Mon, Apr 25, 2011 at 10:19 AM, Frank Terbeck wrote:
>> [...]
>>>> This is certainly better than what we did before (which was
>>>> "nothing"). Does `gitk' support all `git-log' options?
>>>
>>> It allows them, but some of them are ignored.
>>
>> Ah okay.  I've committed the patch then. Thanks!
>>
>> Regards, Frank
>
> The patch doesn't work for me. gitk <tab> just lists files names,
> gitk --<tab> lists no completions. git log <tab> works fine. _git
> is correctly loaded and other changes in it work fine. What am I
> doing wrong here?

The "#compdef" line changed.  Thus, you'll need to remove ~/.zcompdump
and restart zsh.

Regards, Frank


  reply	other threads:[~2011-04-25 12:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-22 17:43 Felipe Contreras
2011-04-25  8:19 ` Frank Terbeck
2011-04-25 11:16   ` Felipe Contreras
2011-04-25 11:49     ` Frank Terbeck
2011-04-25 12:28       ` Simon Ruderich
2011-04-25 12:36         ` Frank Terbeck [this message]
2011-04-25 13:23           ` [PATCH] _git: Add support for tig similar to gitk. (Was: [PATCH] _git: fix gitk) Simon Ruderich
2011-04-25 15:03             ` [PATCH] _git: Add support for tig similar to gitk Frank Terbeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878vuymrsp.fsf@ft.bewatermyfriend.org \
    --to=ft@bewatermyfriend.org \
    --cc=simon@ruderich.org \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).