From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-29039-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 10814 invoked by alias); 25 Apr 2011 12:38:56 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 29039
Received: (qmail 21353 invoked from network); 25 Apr 2011 12:38:54 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,
	SPF_HELO_PASS autolearn=ham version=3.3.1
Received-SPF: none (ns1.primenet.com.au: domain at bewatermyfriend.org does not designate permitted sender hosts)
From: Frank Terbeck <ft@bewatermyfriend.org>
To: Simon Ruderich <simon@ruderich.org>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] _git: fix gitk
In-Reply-To: <20110425122823.GA16924@ruderich.org> (Simon Ruderich's message
	of "Mon, 25 Apr 2011 14:28:23 +0200")
References: <1303494181-10348-1-git-send-email-felipe.contreras@gmail.com>
	<87liyyn3ov.fsf@ft.bewatermyfriend.org>
	<BANLkTimw4a_XDBLmUZP7MTyTpD26W1LswA@mail.gmail.com>
	<87ei4qmtyb.fsf@ft.bewatermyfriend.org>
	<20110425122823.GA16924@ruderich.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
Date: Mon, 25 Apr 2011 14:36:22 +0200
Message-ID: <878vuymrsp.fsf@ft.bewatermyfriend.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Df-Sender: 430444

Simon Ruderich wrote:
> On Mon, Apr 25, 2011 at 01:49:48PM +0200, Frank Terbeck wrote:
>> Felipe Contreras wrote:
>>> On Mon, Apr 25, 2011 at 10:19 AM, Frank Terbeck wrote:
>> [...]
>>>> This is certainly better than what we did before (which was
>>>> "nothing"). Does `gitk' support all `git-log' options?
>>>
>>> It allows them, but some of them are ignored.
>>
>> Ah okay.  I've committed the patch then. Thanks!
>>
>> Regards, Frank
>
> The patch doesn't work for me. gitk <tab> just lists files names,
> gitk --<tab> lists no completions. git log <tab> works fine. _git
> is correctly loaded and other changes in it work fine. What am I
> doing wrong here?

The "#compdef" line changed.  Thus, you'll need to remove ~/.zcompdump
and restart zsh.

Regards, Frank