From: Frank Terbeck <ft@bewatermyfriend.org>
To: Marc Finet <m.dreadlock@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] vcs_info git: fix applied patch detection on git am
Date: Thu, 09 Oct 2014 17:05:52 +0200 [thread overview]
Message-ID: <87a955471r.fsf@ft.bewatermyfriend.org> (raw)
In-Reply-To: <20141009002445.7d6c82a5@mlap.lactee> (Marc Finet's message of "Thu, 9 Oct 2014 00:24:45 +0200")
Marc Finet wrote:
> git-am also uses .git/rebase-apply for patch list but
> the file original-commit does not exist (as no commit exist).
> This patch handles both git rebase and git am. Also:
> - get the first line (rather than the first char) when the message
> contains only one line;
> - remove unused function (ironically that should have been used here).
This looks fine. Mikael has a point, but that should probably be
attached everywhere in vcs_info.
Regards, Frank
prev parent reply other threads:[~2014-10-09 15:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 22:24 Marc Finet
2014-10-08 22:35 ` Mikael Magnusson
2014-10-09 15:05 ` Frank Terbeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a955471r.fsf@ft.bewatermyfriend.org \
--to=ft@bewatermyfriend.org \
--cc=m.dreadlock@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).