From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-33402-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 27719 invoked by alias); 9 Oct 2014 15:22:03 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 33402
Received: (qmail 9527 invoked from network); 9 Oct 2014 15:22:01 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,
	SPF_HELO_PASS autolearn=ham version=3.3.2
From: Frank Terbeck <ft@bewatermyfriend.org>
To: Marc Finet <m.dreadlock@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] vcs_info git: fix applied patch detection on git am
In-Reply-To: <20141009002445.7d6c82a5@mlap.lactee> (Marc Finet's message of
	"Thu, 9 Oct 2014 00:24:45 +0200")
References: <20141009002445.7d6c82a5@mlap.lactee>
User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.93 (gnu/linux)
Date: Thu, 09 Oct 2014 17:05:52 +0200
Message-ID: <87a955471r.fsf@ft.bewatermyfriend.org>
MIME-Version: 1.0
Content-Type: text/plain
X-Df-Sender: NDMwNDQ0

Marc Finet wrote:
> git-am also uses .git/rebase-apply for patch list but
> the file original-commit does not exist (as no commit exist).
> This patch handles both git rebase and git am. Also:
>  - get the first line (rather than the first char) when the message
>    contains only one line;
>  - remove unused function (ironically that should have been used here).

This looks fine. Mikael has a point, but that should probably be
attached everywhere in vcs_info.


Regards, Frank