From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24159 invoked by alias); 8 Apr 2013 12:30:29 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 31243 Received: (qmail 5995 invoked from network); 8 Apr 2013 12:30:26 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 Received-SPF: none (ns1.primenet.com.au: domain at bewatermyfriend.org does not designate permitted sender hosts) From: Frank Terbeck To: zsh-workers@zsh.org Subject: Re: version.h and ChangeLog In-Reply-To: <20130407192324.5bde3a2b@pws-pc.ntlworld.com> (Peter Stephenson's message of "Sun, 7 Apr 2013 19:23:24 +0100") References: <130407103829.ZM487@torch.brasslantern.com> <20130407192324.5bde3a2b@pws-pc.ntlworld.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) Date: Mon, 08 Apr 2013 14:30:12 +0200 Message-ID: <87bo9pnr1n.fsf@ft.bewatermyfriend.org> MIME-Version: 1.0 Content-Type: text/plain X-Df-Sender: [pbs]MzQ5NTM4 Peter Stephenson wrote: > On Sun, 07 Apr 2013 10:38:29 -0700 > Bart Schaefer wrote: >> As we're no longer generating version.h from the revision tag in ChangeLog, >> should we delete the last five lines of ChangeLog? >> >> If the $"Revision: $" is still useful for some reason, we should at least >> remove the text that says that ZSH_PATCHLEVEL is generated from that tag. > > As far as I can see, it isn't and those lines should just go. About $ZSH_PATCHLEVEL: Did someone try if the variable is handled/set properly when building from a tarball, when "git describe" isn't available - and if it was would throw an error? If not, we should look at that so the next release will go smoothly. Regards, Frank