From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15937 invoked by alias); 7 Jan 2012 21:48:20 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 30102 Received: (qmail 28617 invoked from network); 7 Jan 2012 21:48:07 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 Received-SPF: none (ns1.primenet.com.au: domain at bewatermyfriend.org does not designate permitted sender hosts) From: Frank Terbeck To: zsh-workers@zsh.org Subject: Re: PATCH: Restore `LC_ALL' when setting `LANG' In-Reply-To: <20120107200402.371eece3@pws-pc.ntlworld.com> (Peter Stephenson's message of "Sat, 7 Jan 2012 20:04:02 +0000") References: <20120102132718.GA12143@gatsby.mbjnet.dk> <87fwfyb2if.fsf@ft.bewatermyfriend.org> <20120102154714.GA20663@gatsby.mbjnet.dk> <87wr9a9ely.fsf@ft.bewatermyfriend.org> <20120103111049.GA5673@gatsby.mbjnet.dk> <87sjjw98yl.fsf@ft.bewatermyfriend.org> <87k458974e.fsf@ft.bewatermyfriend.org> <2012-01-03T15-59-18@devnull.michael-prokop.at> <87boqk95we.fsf@ft.bewatermyfriend.org> <87y5to7qob.fsf@ft.bewatermyfriend.org> <20120104021641.GD4513@xvii.vinc17.org> <20120104173017.3b10a803@pws-pc.ntlworld.com> <1490C10C-33CA-4A1F-8579-066B77773A40@kba.biglobe.ne.jp> <20120107200402.371eece3@pws-pc.ntlworld.com> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.91 (gnu/linux) Date: Sat, 07 Jan 2012 22:41:19 +0100 Message-ID: <87boqf8a2o.fsf@ft.bewatermyfriend.org> MIME-Version: 1.0 Content-Type: text/plain X-Df-Sender: [pbs]MzQ5NTM4 Peter Stephenson wrote: > On Fri, 6 Jan 2012 15:03:54 +0900 > "Jun T." wrote: >> Instead of adding LC_ALL to lc_names[], I think it better >> not calling setlocale() at all if LC_ALL is non-empty. > > I can see that's a reasonably minimal change. As long as Frank's happy > that fixes the problem, I can apply it. I don't know if it's the better fix, but then I'm pretty ignorant about matters of `locale'... I can confirm that Jun's patch seems to fix the bug as well. So I don't mind either way. Regards, Frank