From: Philippe Troin <phil@fifi.org>
To: Oliver Kiddle <okiddle@yahoo.co.uk>
Cc: Zsh workers <zsh-workers@sunsite.dk>
Subject: Re: LC_NUMERIC=fr_FR and floating point arithmetics
Date: 11 Mar 2003 19:32:07 -0800 [thread overview]
Message-ID: <87bs0hdzuw.fsf@ceramic.fifi.org> (raw)
In-Reply-To: <16574.1047378921@finches.logica.co.uk>
Oliver Kiddle <okiddle@yahoo.co.uk> writes:
> Index: Src/params.c
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Src/params.c,v
> retrieving revision 1.69
> diff -u -r1.69 params.c
> --- Src/params.c 31 Oct 2002 18:32:40 -0000 1.69
> +++ Src/params.c 11 Mar 2003 10:00:10 -0000
> @@ -3417,6 +3417,7 @@
> convfloat(double dval, int digits, int flags, FILE *fout)
> {
> char fmt[] = "%.*e";
> + char *prev_locale, *ret;
>
> /*
> * The difficulty with the buffer size is that a %f conversion
> @@ -3451,16 +3452,24 @@
> digits--;
> }
> }
> +#ifdef USE_LOCALE
> + prev_locale = dupstring(setlocale(LC_NUMERIC, NULL));
> + setlocale(LC_NUMERIC, "POSIX");
> +#endif
> if (fout) {
> fprintf(fout, fmt, digits, dval);
> - return NULL;
> + ret = NULL;
> } else {
> VARARR(char, buf, 512 + digits);
> sprintf(buf, fmt, digits, dval);
> if (!strchr(buf, 'e') && !strchr(buf, '.'))
> strcat(buf, ".");
> - return dupstring(buf);
> + ret = dupstring(buf);
> }
> +#ifdef USE_LOCALE
> + if (prev_locale) setlocale(LC_NUMERIC, prev_locale);
> +#endif
> + return ret;
> }
>
> /* Start a parameter scope */
Aren't you leaking a copy of the current locale (via dupstring())
every time?
Phil.
next prev parent reply other threads:[~2003-03-12 3:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-24 17:45 Stephane CHAZELAS
2003-03-10 8:58 ` Oliver Kiddle
2003-03-10 19:25 ` Zefram
2003-03-11 10:35 ` Oliver Kiddle
2003-03-12 3:32 ` Philippe Troin [this message]
2003-03-12 8:30 ` Oliver Kiddle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bs0hdzuw.fsf@ceramic.fifi.org \
--to=phil@fifi.org \
--cc=okiddle@yahoo.co.uk \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).