From: Frank Terbeck <ft@bewatermyfriend.org>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-workers@zsh.org
Subject: Re: PATCH: vcs_info: Set NO_warn_create_global option
Date: Sun, 21 Feb 2010 21:06:35 +0100 [thread overview]
Message-ID: <87d3zy8ib8.fsf@ft.bewatermyfriend.org> (raw)
In-Reply-To: <100221092514.ZM24056@torch.brasslantern.com> (Bart Schaefer's message of "Sun, 21 Feb 2010 09:25:14 -0800")
Bart Schaefer wrote:
> On Feb 21, 3:53pm, Frank Terbeck wrote:
>}
>} zstyle -e ':vcs_info:git:*' \
>} check-for-changes 'estyle-cfc && reply=( true ) || reply=( false )'
>}
>} That however, welcomes me with this nice warning:
>} VCS_INFO_get_data_git:49: array parameter reply created globally in function
>
>} So, there are three options:
>} a) Get the big hammer and just disable `warn_create_global' in
>} vcs_info.
>} b) Use a smaller hammer, and create a wrapper function around zstyle
>} for vcs_info, that disables the option locally.
>} c) Disable `warn_create_global' in code executed by "zstyle -e". Or
>} make `reply' and `REPLY' special in that case. Or whatever makes the
>} most sense.
>
> There's another option
>
> b.5) Write the style like this:
>
> zstyle -e ':vcs_info:git:*' \
> check-for-changes 'typeset -g reply; \
> estyle-cfc && reply=( true ) || reply=( false )'
Hm yeah. But I think it would be way more convenient to let the shell do
that automatically, since at least here `reply' is supposed to be used.
> Also, rather than (c) I might suggest
>
> d) Suppress warn_create_global for the parameters "reply" and "REPLY"
> at all times. In fact it probably ought to be suppressed for STTY
> and a few others in the "Parameters Used By The Shell" section of
> the manual.
I guess, you've seen the patch I set for "c)". That was easy enough.
You're probably right that this should always apply to `reply', `REPLY'
and the like. I don't know how to do that, though. Would you always have
such parameters be available globally, even after an `unset'?
Any ideas where to apply the leverage?
Regards, Frank
--
In protocol design, perfection has been reached not when there is
nothing left to add, but when there is nothing left to take away.
-- RFC 1925
next prev parent reply other threads:[~2010-02-21 20:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-21 14:53 Frank Terbeck
2010-02-21 15:09 ` PATCH: Disable WARN_CREATE_GLOBAL in 'zstyle -e' code Frank Terbeck
2010-02-21 15:18 ` Frank Terbeck
2010-02-21 17:25 ` PATCH: vcs_info: Set NO_warn_create_global option Bart Schaefer
2010-02-21 20:06 ` Frank Terbeck [this message]
2010-02-21 21:17 ` Bart Schaefer
2010-02-21 21:34 ` Frank Terbeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d3zy8ib8.fsf@ft.bewatermyfriend.org \
--to=ft@bewatermyfriend.org \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).