zsh-workers
 help / color / mirror / code / Atom feed
From: Frank Terbeck <ft@bewatermyfriend.org>
To: Daniel Hahler <dhahler@gmail.com>
Cc: Zsh Hackers' List <zsh-workers@zsh.org>
Subject: Re: vcs_info: quoting (backticks) in git_patches_applied
Date: Thu, 09 Oct 2014 17:04:13 +0200	[thread overview]
Message-ID: <87eguh474i.fsf@ft.bewatermyfriend.org> (raw)
In-Reply-To: <5435B523.5010804@thequod.de> (Daniel Hahler's message of "Thu, 09 Oct 2014 00:05:23 +0200")

Daniel Hahler wrote:
> On 08.10.2014 23:09, Frank Terbeck wrote:
[...]
> The quoting needs to get applied to all places where the Git sources
> are being read in Functions/VCS_Info/Backends/VCS_INFO_get_data_git
> then probably, and also in the code for other VCS (e.g. hg).
>
>> (I suppose your problem is that your hook
>> does returns a - maybe even single - backtick and you use the
>> prompt_subst option which would cause problems) as the rest of the
>> configuration requires.
>
> That's correct.

I guess we could introduce a function that does some form of
post-processing , if a style is set. Valid settings could be "quote" or
"strip" and "function", the latter would dispatch to a named function,
for example for the user to get full control. That function could be
used everywhere where a string from an external program is used.

That way, prompt_subst users (if you don't use prompt_subst, which is
the default, none of this is an issue) can get post-processing if they
like. Actually, we could make the default depend on the state of the
option when vcs_info initialises.

Unfortunately, I can't look into it right now due to lack of spare time.


Regards, Frank


  reply	other threads:[~2014-10-09 15:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-08 15:25 Daniel Hahler
2014-10-08 21:09 ` Frank Terbeck
2014-10-08 22:05   ` Daniel Hahler
2014-10-09 15:04     ` Frank Terbeck [this message]
2014-10-08 22:28   ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eguh474i.fsf@ft.bewatermyfriend.org \
    --to=ft@bewatermyfriend.org \
    --cc=dhahler@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).