From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21538 invoked by alias); 24 Jan 2010 22:32:56 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 27639 Received: (qmail 16752 invoked from network); 24 Jan 2010 22:32:54 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.2.5 Received-SPF: none (ns1.primenet.com.au: domain at bewatermyfriend.org does not designate permitted sender hosts) From: Frank Terbeck To: Peter Stephenson Cc: zsh-workers@zsh.org, zsh@benizi.com, schaefer@brasslantern.com, richih.mailinglist@gmail.com Subject: Re: PATCH: Add `sourcetrace' option In-Reply-To: <20100124211240.3d84f802@pws-pc> (Peter Stephenson's message of "Sun, 24 Jan 2010 21:12:40 +0000") References: <87y6joz7kf.fsf@ft.bewatermyfriend.org> <1264292296-5459-1-git-send-email-ft@bewatermyfriend.org> <20100124211240.3d84f802@pws-pc> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) Date: Sun, 24 Jan 2010 23:27:33 +0100 Message-ID: <87fx5vw33e.fsf@ft.bewatermyfriend.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Df-Sender: 430444 Peter Stephenson writes: > Frank Terbeck wrote: >> Here's an updated patch. Thanks to everyone who reviewed the previous >> attempts. > > I'm just toying with this variant... the difference is this moves the > output down until after the script name etc. is set up, and uses PS4 > (like the xtrace option), so the output is more configurable. For > example, I get: > > +/etc/zshenv:1> > +/home/pws/.zshenv:1> > +/home/pws/.profile:1> > +/home/pws/.zshrc:1> > /home/pws/.aliasrc:1:> > /home/pws/.compinstall:1:> > /home/pws/.zcompdump_4.3.10-dev-1_pws:1:> > > (the change in the middle is because I tweak PS4 to remove the "+" in > .zshrc, for no good reason I can now think of, as well as adding %_, and > there's only one global file because .zshenv sets NO_GLOBAL_RCS.) > > I'm not particularly set on this but it seems more powerful without > losing anything obvious. The documentation would need tweaking. Certainly preferable. Would the documentation really need updating? The entry for `XTRACE' doesn't mention $PS4 either. And the overall behaviour doesn't differ from my initial approach, does it? Regards, Frank -- In protocol design, perfection has been reached not when there is nothing left to add, but when there is nothing left to take away. -- RFC 1925