zsh-workers
 help / color / mirror / code / Atom feed
From: Frank Terbeck <ft@bewatermyfriend.org>
To: Nikolai Weibull <now@bitwi.se>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH 3/4] Fix git-branch -[dD] -r completion
Date: Sat, 19 Mar 2011 10:29:54 +0100	[thread overview]
Message-ID: <87hbazh2zx.fsf@ft.bewatermyfriend.org> (raw)
In-Reply-To: <AANLkTi=N=xdbF41TwVaLAbByYycj_HKTjb3FFhFBb4j5@mail.gmail.com> (Nikolai Weibull's message of "Sat, 19 Mar 2011 10:10:59 +0100")

Nikolai Weibull wrote:
> On Fri, Mar 18, 2011 at 23:26, Frank Terbeck <ft@bewatermyfriend.org> wrote:
>> Hm, with this patch, this:
>>
>> % git branch -d -r <tab>
>>
>> works. But this:
>>
>> % git -r -d <tab>
>>
>> doesn't.
>>
>> I suppose, that's not intentional?
>
> Well, it depends on what you’re after.  Writing -r first hints that
> you want to list branches, not delete them.  If you look at the
> synopsis in the man page, that’s how I’ve done it.  Does anyone have a
> strong opinion on how this should be done?

I think _git should offer both ways simply because git accepts both
ways. Further down the git-branch(1) manpage, it states "List or delete
(if used with -d) [...]". So it's *with*, not *after*.

IMHO, _git behaving that way would make sense.

Regards, Frank


  reply	other threads:[~2011-03-19  9:38 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-18 21:35 Small patches o git completion Nikolai Weibull
2011-03-18 21:35 ` [PATCH 1/4] Fix typo Nikolai Weibull
2011-03-18 21:35 ` [PATCH 2/4] Only show modified files for git-checkout without tree Nikolai Weibull
2011-03-18 21:35 ` [PATCH 3/4] Fix git-branch -[dD] -r completion Nikolai Weibull
2011-03-18 22:26   ` Frank Terbeck
2011-03-19  2:55     ` Benjamin R. Haskell
2011-03-19  8:21       ` Frank Terbeck
2011-03-19  9:10     ` Nikolai Weibull
2011-03-19  9:29       ` Frank Terbeck [this message]
2011-03-19 13:19       ` Benjamin R. Haskell
2011-05-29 15:10         ` Nikolai Weibull
2011-03-18 21:35 ` [PATCH 4/4] Fix typo in git-send-email completion Nikolai Weibull
2011-03-18 22:43 ` Small patches o git completion Frank Terbeck
2011-03-19 22:15 ` Simon Ruderich
2011-04-15 14:08   ` Simon Ruderich
2011-04-15 14:24     ` Nikolai Weibull
2011-04-15 14:37       ` Mikael Magnusson
2011-04-15 14:44         ` Nikolai Weibull
2011-04-15 14:49           ` Mikael Magnusson
2011-05-02  8:16             ` [PATCH] Fix -l option for git-tag completion Nikolai Weibull
2011-05-12 16:02               ` Mikael Magnusson
2011-04-15 14:45     ` Small patches o git completion Frank Terbeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hbazh2zx.fsf@ft.bewatermyfriend.org \
    --to=ft@bewatermyfriend.org \
    --cc=now@bitwi.se \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).