From: Philippe Troin <phil@fifi.org>
To: Peter Stephenson <pws@csr.com>
Cc: zsh-workers@sunsite.dk
Subject: Re: Mysteriously changing parameters and options within a function.
Date: 22 Jul 2003 13:00:33 -0700 [thread overview]
Message-ID: <87k7aa5o2m.fsf@ceramic.fifi.org> (raw)
In-Reply-To: <25763.1058806651@csr.com>
Peter Stephenson <pws@csr.com> writes:
> Philippe Troin wrote:
> > However, I get this:
> >
> > % check-missing-locals :
> > check-missing-locals: changed option braceexpand: on vs. off
> > check-missing-locals: unset parameter LANG
> > check-missing-locals: unset parameter LC_ALL
> > check-missing-locals: unset parameter LC_COLLATE
> > check-missing-locals: unset parameter LC_CTYPE
> > check-missing-locals: unset parameter LC_MESSAGES
> > check-missing-locals: unset parameter LC_NUMERIC
> > check-missing-locals: unset parameter LC_TIME
> >
> > What makes LANG, LC_* and the braceexpand option appear to be in
> > different states at the beginning and the end of the function?
>
> I don't think the parameter module should be showing unset parameters
> when you ask it for a list of parameters which are set.
>
> I can't show up the bug with braceexpand, which is probably something
> different. There was a bug fixed back in March:
>
> * 18325: Src/Modules/parameter.c: options on by default weren't
> handled correctly.
>
> but I don't think that's it either.
I cannot see the braceexpand problem with the current CVS tree.
>
> Index: Src/Modules/parameter.c
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Src/Modules/parameter.c,v
> retrieving revision 1.23
> diff -u -r1.23 parameter.c
> --- Src/Modules/parameter.c 7 Mar 2003 12:31:12 -0000 1.23
> +++ Src/Modules/parameter.c 21 Jul 2003 16:54:48 -0000
> @@ -181,6 +181,8 @@
>
> for (i = 0; i < realparamtab->hsize; i++)
> for (hn = realparamtab->nodes[i]; hn; hn = hn->next) {
> + if (((Param)hn)->flags & PM_UNSET)
> + continue;
> pm.nam = hn->nam;
> if (func != scancountparams &&
> ((flags & (SCANPM_WANTVALS|SCANPM_MATCHVAL)) ||
I can confirm that this patch fixes the problem for LANG and the LC_*
variables.
Please consider applying the patch to CVS.
Phil.
prev parent reply other threads:[~2003-07-22 20:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-19 2:06 Philippe Troin
2003-07-21 16:57 ` Peter Stephenson
2003-07-22 20:00 ` Philippe Troin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k7aa5o2m.fsf@ceramic.fifi.org \
--to=phil@fifi.org \
--cc=pws@csr.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).