From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6533 invoked by alias); 14 Sep 2014 09:49:40 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 33163 Received: (qmail 13680 invoked from network); 14 Sep 2014 09:49:39 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 From: Frank Terbeck To: Marc Finet Cc: zsh-workers@zsh.org Subject: Re: [PATCH 6/9] vcs_info quilt: fix unapplied detection on sub-directory In-Reply-To: <1410557443-24178-7-git-send-email-m.dreadlock@gmail.com> (Marc Finet's message of "Fri, 12 Sep 2014 23:30:40 +0200") References: <1410557443-24178-1-git-send-email-m.dreadlock@gmail.com> <1410557443-24178-7-git-send-email-m.dreadlock@gmail.com> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.93 (gnu/linux) Date: Sun, 14 Sep 2014 11:47:55 +0200 Message-ID: <87lhpm7ctw.fsf@ft.bewatermyfriend.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Df-Sender: NDMwNDQ0 Marc Finet wrote: > When being in a subdirectory of a "repo" being handled with quilt, > the `quilt unapplied` command returns all the patches because > QUILT_PATCHES is an absolute path (which exists and is a dir) and > quilt considers that .pc should in current directory. > Changing quilt might be overkill and it seems that QUILT_PATCHES > should just be a name, not an absolute path. [...] > - unapplied=3D( ${(f)"$(QUILT_PATCHES=3D$patches $quiltcommand --q= uiltrc /dev/null unapplied 2> /dev/null)"} ) > + unapplied=3D( ${(f)"$(QUILT_PATCHES=3D$(basename $patches) $quil= tcommand --quiltrc /dev/null unapplied 2> /dev/null)"} ) You can't do it like this. With debian-packages for example, quilt patches live in =E2=80=98debian/patches=E2=80=99, which the =E2=80=98basena= me=E2=80=99 call would trim down to =E2=80=98patches=E2=80=99. If you do need special QUILT_PATCHES treatment, you can set a =E2=80=98quit-patches-dir=E2=80=99 style; if the treatment needs to be fanc= y, you can also set the style to a function, which opens up the door to whatever you like. Regards, Frank