From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-28814-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 473 invoked by alias); 28 Feb 2011 12:18:08 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 28814
Received: (qmail 8908 invoked from network); 28 Feb 2011 12:18:05 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,
	SPF_HELO_PASS autolearn=ham version=3.3.1
Received-SPF: none (ns1.primenet.com.au: domain at bewatermyfriend.org does not designate permitted sender hosts)
From: Frank Terbeck <ft@bewatermyfriend.org>
To: <zsh-workers@zsh.org>
Subject: Re: PATCH: Fix multibyte memory allocation in `wcs_ztrdup()'
In-Reply-To: <20110228115510.29590f1d@pwslap01u.europe.root.pri> (Peter
	Stephenson's message of "Mon, 28 Feb 2011 11:55:10 +0000")
References: <1298889300-29679-1-git-send-email-ft@bewatermyfriend.org>
	<20110228115510.29590f1d@pwslap01u.europe.root.pri>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
Date: Mon, 28 Feb 2011 13:04:04 +0100
Message-ID: <87mxlgcqmj.fsf@ft.bewatermyfriend.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Df-Sender: 430444

Peter Stephenson wrote:
> On Mon, 28 Feb 2011 11:35:00 +0100
> Frank Terbeck <ft@bewatermyfriend.org> wrote:
>> This was spotted by Thorsten Glaser from the mirbsd project.
>> 
>> `zalloc()' uses malloc(3) to allocate memory. wcslen(3) returns the
>> number of multibyte *characters* in a given string (N). The
>> destination string will have to be able to store N+1 wchar_ts, not
>> N+1 bytes.
>
> Thanks... and it needs to be a wide NULL (L'0'), too, so another
> lot of parentheses is needed.

Good point. :)