From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-33165-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 29053 invoked by alias); 14 Sep 2014 09:51:00 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 33165
Received: (qmail 26099 invoked from network); 14 Sep 2014 09:50:58 -0000
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,
	SPF_HELO_PASS autolearn=ham version=3.3.2
From: Frank Terbeck <ft@bewatermyfriend.org>
To: Marc Finet <m.dreadlock@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH 5/9] vcs_info quilt: fix standalone detection
In-Reply-To: <1410557443-24178-6-git-send-email-m.dreadlock@gmail.com> (Marc
	Finet's message of "Fri, 12 Sep 2014 23:30:39 +0200")
References: <1410557443-24178-1-git-send-email-m.dreadlock@gmail.com>
	<1410557443-24178-6-git-send-email-m.dreadlock@gmail.com>
User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.93 (gnu/linux)
Date: Sun, 14 Sep 2014 11:42:55 +0200
Message-ID: <87ppey7d28.fsf@ft.bewatermyfriend.org>
MIME-Version: 1.0
Content-Type: text/plain
X-Df-Sender: NDMwNDQ0

Marc Finet wrote:
[...]
> -    if [[ -n "${file}" ]]; then
> -        oldfile=${vcs_comm[detect_need_file]}
> -        vcs_comm[detect_need_file]=${file}
> -    fi
> +    oldfile=${vcs_comm[detect_need_file]}
> +    vcs_comm[detect_need_file]=${file}
>      VCS_INFO_bydir_detect ${dir}
>      ret=$?
> -    [[ -n "${file}" ]] && vcs_comm[detect_need_file]=${oldfile}
> +    vcs_comm[detect_need_file]=${oldfile}

I don't think this changes anything really, but the removing the
conditionals makes the code a bit easier to read. So ACK.


Regards, Frank