zsh-workers
 help / color / mirror / code / Atom feed
From: Frank Terbeck <ft@bewatermyfriend.org>
To: "Benjamin R. Haskell" <zsh@benizi.com>
Cc: Nikolai Weibull <now@bitwi.se>,  zsh-workers@zsh.org
Subject: Re: [PATCH 3/4] Fix git-branch -[dD] -r completion
Date: Sat, 19 Mar 2011 09:21:45 +0100	[thread overview]
Message-ID: <87pqpnh65i.fsf@ft.bewatermyfriend.org> (raw)
In-Reply-To: <alpine.LNX.2.01.1103182244390.22141@hp> (Benjamin R. Haskell's message of "Fri, 18 Mar 2011 22:55:40 -0400 (EDT)")

Benjamin R. Haskell wrote:
> On Fri, 18 Mar 2011, Frank Terbeck wrote:
>
>> Hm, with this patch, this:
>>
>> % git branch -d -r <tab>
>>
>> works. But this:
>>
>> % git -r -d <tab>
>>
>> doesn't.
>
> Without 'branch'?

Sorry typo. It doesn't work *with* branch.

>> I suppose, that's not intentional?
>
> With the 'branch' there, both:
>
> (i) git branch -d -r <tab>
> and
> (ii) git branch -r -d <tab>
>
> seem to behave identically whether or not this patch is applied.  With
> or without the patch (i) seems fine AFAICT.  But (ii) doesn't seem to
> complete branches, even though I think it should.

They don't for me.

% git branch -d -r <tab>
- remote branch name -
origin/debian           origin/upstream       
origin/HEAD             origin/upstream-import
origin/master           zsh.git/master

And:

% git branch -r -d <tab>

results in

% git branch -r -d -

If I tab again, I get:

% git branch -r -d -<tab>
- option -
--abbrev         -- set minimum SHA1 display-length                                                                                                                 
--color          -- turn on branch coloring                                                                                                                         
--no-abbrev      -- do not abbreviate sha1s                                                                                                                         
--no-color       -- turn off branch coloring                                                                                                                        
-r               -- delete remote-tracking branches                                                                                                                 
--verbose    -v  -- show SHA1 and commit subject line for each head

Regards, Frank

-- 
In protocol design, perfection has been reached not when there is
nothing left to add, but when there is nothing left to take away.
                                                  -- RFC 1925


  reply	other threads:[~2011-03-19  8:25 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-18 21:35 Small patches o git completion Nikolai Weibull
2011-03-18 21:35 ` [PATCH 1/4] Fix typo Nikolai Weibull
2011-03-18 21:35 ` [PATCH 2/4] Only show modified files for git-checkout without tree Nikolai Weibull
2011-03-18 21:35 ` [PATCH 3/4] Fix git-branch -[dD] -r completion Nikolai Weibull
2011-03-18 22:26   ` Frank Terbeck
2011-03-19  2:55     ` Benjamin R. Haskell
2011-03-19  8:21       ` Frank Terbeck [this message]
2011-03-19  9:10     ` Nikolai Weibull
2011-03-19  9:29       ` Frank Terbeck
2011-03-19 13:19       ` Benjamin R. Haskell
2011-05-29 15:10         ` Nikolai Weibull
2011-03-18 21:35 ` [PATCH 4/4] Fix typo in git-send-email completion Nikolai Weibull
2011-03-18 22:43 ` Small patches o git completion Frank Terbeck
2011-03-19 22:15 ` Simon Ruderich
2011-04-15 14:08   ` Simon Ruderich
2011-04-15 14:24     ` Nikolai Weibull
2011-04-15 14:37       ` Mikael Magnusson
2011-04-15 14:44         ` Nikolai Weibull
2011-04-15 14:49           ` Mikael Magnusson
2011-05-02  8:16             ` [PATCH] Fix -l option for git-tag completion Nikolai Weibull
2011-05-12 16:02               ` Mikael Magnusson
2011-04-15 14:45     ` Small patches o git completion Frank Terbeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pqpnh65i.fsf@ft.bewatermyfriend.org \
    --to=ft@bewatermyfriend.org \
    --cc=now@bitwi.se \
    --cc=zsh-workers@zsh.org \
    --cc=zsh@benizi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).