From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16016 invoked by alias); 20 Aug 2018 12:35:53 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43318 Received: (qmail 2145 invoked by uid 1010); 20 Aug 2018 12:35:53 -0000 X-Qmail-Scanner-Diagnostics: from smtprelay07.ispgateway.de by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(134.119.228.100):SA:0(-2.6/5.0):. Processed in 1.575556 secs); 20 Aug 2018 12:35:53 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: ft@bewatermyfriend.org X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | From: Frank Terbeck To: Daniel Shahaf Cc: zsh-workers@zsh.org Subject: Re: [PATCH 2/2] vcs_info git: For the branch name, try to find a symbolic name before falling back to a raw commit hex. In-Reply-To: <1534681967.2423927.1478973456.762A6FF2@webmail.messagingengine.com> (Daniel Shahaf's message of "Sun, 19 Aug 2018 12:32:47 +0000") References: <20180818155719.23574-1-danielsh@tarpaulin.shahaf.local2> <20180818155719.23574-2-danielsh@tarpaulin.shahaf.local2> <87y3d3mmpz.fsf@ft.bewatermyfriend.org> <1534681967.2423927.1478973456.762A6FF2@webmail.messagingengine.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Date: Mon, 20 Aug 2018 13:45:32 +0200 Message-ID: <87r2itmfc3.fsf@ft.bewatermyfriend.org> MIME-Version: 1.0 Content-Type: text/plain X-Df-Sender: NDMwNDQ0 Daniel Shahaf wrote: > 1. Adding knobs induces a maintenance cost going forward. Is that cost > justified in this case? We can always add the knob later if there's > demand for it, but it's harder to take away behaviour once it has > been released. > > 2. At what point in the if-chain do we raise the white flag^W^W^W^W > check the "early exit?" style? > > I suppose we could overload the `use-simple` style for this purpose (the > git backend doesn't currently use that style). The `get-revision` style > is also relevant. Yeah. The git backend is pretty complex as it is. Maybe it's not worth it, to make this configurable. I don't know.