From: Frank Terbeck <ft@bewatermyfriend.org>
To: zsh-workers@zsh.org
Subject: Re: [PATCH] vcs_info git: Fix stagedstr for empty repos
Date: Mon, 02 Jun 2014 15:19:34 +0200 [thread overview]
Message-ID: <87r4374ffd.fsf@ft.bewatermyfriend.org> (raw)
In-Reply-To: <20140602130028.GD1871@tarsus.local2> (Daniel Shahaf's message of "Mon, 2 Jun 2014 13:00:28 +0000")
Daniel Shahaf wrote:
[...]
>> I'm with Aaron on this one. IIRC, git uses the diff-index command in
>> various places, so I don't think it'll be removed anytime soon.
>
> My concern was not with using diff-index but with using the empty tree.
> Since Aaron says using it would be robust, let's just use it. Attached.
I see. I suppose this would only change, if git decides to change its
hashing algorithm. That's a problem for another day, I guess. :)
>> If you don't want the second variant to be forgotten, you can always put
>> it into the change's commit message. But in the code I'd just use the
>> variant that you think is faster (if only theoretically).
>
> It's mentioned in this thread, good enough for me.
Great, thanks! Pushed.
Regards, Frank
next prev parent reply other threads:[~2014-06-02 13:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-01 2:26 Daniel Shahaf
2014-06-01 12:33 ` Aaron Schrab
2014-06-02 8:14 ` [PATCH] " Frank Terbeck
2014-06-02 13:00 ` Daniel Shahaf
2014-06-02 13:19 ` Frank Terbeck [this message]
2014-06-02 18:21 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4374ffd.fsf@ft.bewatermyfriend.org \
--to=ft@bewatermyfriend.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).