From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19760 invoked by alias); 2 Jun 2014 13:21:26 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 32663 Received: (qmail 7686 invoked from network); 2 Jun 2014 13:21:23 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 From: Frank Terbeck To: zsh-workers@zsh.org Subject: Re: [PATCH] vcs_info git: Fix stagedstr for empty repos In-Reply-To: <20140602130028.GD1871@tarsus.local2> (Daniel Shahaf's message of "Mon, 2 Jun 2014 13:00:28 +0000") References: <20140601022653.GE1820@tarsus.local2> <87vbsj4tk1.fsf@ft.bewatermyfriend.org> <20140602130028.GD1871@tarsus.local2> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) Date: Mon, 02 Jun 2014 15:19:34 +0200 Message-ID: <87r4374ffd.fsf@ft.bewatermyfriend.org> MIME-Version: 1.0 Content-Type: text/plain X-Df-Sender: NDMwNDQ0 Daniel Shahaf wrote: [...] >> I'm with Aaron on this one. IIRC, git uses the diff-index command in >> various places, so I don't think it'll be removed anytime soon. > > My concern was not with using diff-index but with using the empty tree. > Since Aaron says using it would be robust, let's just use it. Attached. I see. I suppose this would only change, if git decides to change its hashing algorithm. That's a problem for another day, I guess. :) >> If you don't want the second variant to be forgotten, you can always put >> it into the change's commit message. But in the code I'd just use the >> variant that you think is faster (if only theoretically). > > It's mentioned in this thread, good enough for me. Great, thanks! Pushed. Regards, Frank