From: Frank Terbeck <ft@bewatermyfriend.org>
To: Seth House <seth@eseth.com>
Cc: Ioannis Koutras <ioannis.koutras@gmail.com>, zsh-workers@zsh.org
Subject: Re: vcs_info on a hg repository with a git subrepository; actionformats works ok, formats does not
Date: Mon, 17 Sep 2012 23:28:41 +0200 [thread overview]
Message-ID: <87r4q09w52.fsf@ft.bewatermyfriend.org> (raw)
In-Reply-To: <CABsXarGXg_m1i4tjPbUS5Fz+_BOGqbKKoG5-wKF01rOKgsKvhA@mail.gmail.com> (Seth House's message of "Mon, 17 Sep 2012 12:53:29 -0700")
[moving thread to -workers]
Seth House wrote:
> On Mon, Sep 17, 2012 at 9:57 AM, Seth House <seth@eseth.com> wrote:
[...]
>> The --debug flag is used to get hg to output the full sha.
>
> Relying on --debug here is not ideal. Something like this was bound to
> happen eventually. Unfortunately, I don't believe there's a way to
> retrieve all info of interest to VCS_Info with a single call to
> Mercurial. (Invoking the Python interpreter is too slow to do more
> than once while drawing the shell prompt.)
Indeed. :-/
> I have done quite a bit of experimenting, searching, and asking on
> this.
>
> I propose one of the following:
>
> 1) Alter the hg backend to work without the full 40-char hash.
>
> The ``hg id`` command will always return a unique hash. The only thing
> the full hash is being used for in the hg backend is comparisons with
> MQ patches and that can be changed to be a left-match instead. We can
> document why the full hash isn't available and if users are expecting
> 40-chars we can give an example of how to pad the value with spaces.
> This changes existing behavior.
>
> 2) Continue using --debug and add a workaround for this issue.
>
> It's plausible that the output of interest will always appear at the
> bottom of the debug output. Mercurial does have a
> backward-compatibility policy for its output formats but this does not
> extend to debug output (obviously).
>
> FWIW, my personal preference is the first option as I feel the 40-char
> hash is rarely desired or useful in a shell prompt.
>
> Thoughts?
Hm. Ideally, I'd like there to be the least possible impact on existing
setups. But then and again having `--debug' in there was always
bothering me a little. I'm undecided.
I know, however, that I don't want to introduce another style again to
make this optional.
I'll think about it until tomorrow. If a user of the hg backend has a
strong opinion on this, speak up.
Regards, Frank
--
In protocol design, perfection has been reached not when there is
nothing left to add, but when there is nothing left to take away.
-- RFC 1925
next parent reply other threads:[~2012-09-17 21:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAPeCK2MsfJJxq0v1_eKA1uo9aJ1Mn-8+B-_YAPit-V_A4MFY6A@mail.gmail.com>
[not found] ` <87boh4bt5l.fsf@ft.bewatermyfriend.org>
[not found] ` <CAPeCK2MRukgGxx=nGhRs8oPMz=zPfj+XDcmf4Vaz+YJ+JZUEXw@mail.gmail.com>
[not found] ` <877grsbrz7.fsf@ft.bewatermyfriend.org>
[not found] ` <CAPeCK2PwM=GNAhxqmn-bMiDfKhpXJpOGgCqs05KJvMg1RsqkNg@mail.gmail.com>
[not found] ` <87zk4oabam.fsf@ft.bewatermyfriend.org>
[not found] ` <CABsXarH6MMNEsnUG=8O-VirH6biFKR9gMKQ7RcNgtKmQVw_Ltg@mail.gmail.com>
[not found] ` <87vcfca9sa.fsf@ft.bewatermyfriend.org>
[not found] ` <CABsXarF5CM=CjhrrCsPBdY0es2SpY=dQC2116grsq4rYDPsE=g@mail.gmail.com>
[not found] ` <CABsXarGXg_m1i4tjPbUS5Fz+_BOGqbKKoG5-wKF01rOKgsKvhA@mail.gmail.com>
2012-09-17 21:28 ` Frank Terbeck [this message]
2012-09-19 7:34 ` Frank Terbeck
2012-09-19 15:14 ` Seth House
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r4q09w52.fsf@ft.bewatermyfriend.org \
--to=ft@bewatermyfriend.org \
--cc=ioannis.koutras@gmail.com \
--cc=seth@eseth.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).