From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5500 invoked by alias); 27 Apr 2011 08:50:46 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 29083 Received: (qmail 6441 invoked from network); 27 Apr 2011 08:50:40 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.1 Received-SPF: none (ns1.primenet.com.au: domain at bewatermyfriend.org does not designate permitted sender hosts) From: Frank Terbeck To: Felipe Contreras Cc: Nikolai Weibull , Mikael Magnusson , zsh-workers@zsh.org Subject: Re: Slowness issue with git completion In-Reply-To: (Felipe Contreras's message of "Wed, 27 Apr 2011 11:30:12 +0300") References: <87liyw7t0o.fsf@ft.bewatermyfriend.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) Date: Wed, 27 Apr 2011 10:47:59 +0200 Message-ID: <87sjt43wsg.fsf@ft.bewatermyfriend.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Df-Sender: 430444 Felipe Contreras wrote: > On Wed, Apr 27, 2011 at 9:11 AM, Nikolai Weibull wrote: >>> Are you interested in fixing this use-case even if it means to make >>> some compromises in correctness or not? >> >> No, I=E2=80=99m not. > > I am not used to zsh development, so is Nikolai's opinion shared by > the rest? Even if I provide a fix that make things slightly less > correct but usable, you wouldn't take the patch? I for one, am very fond of the way completion is done (albeit, not its performance in huge repositories). It actually *saves* me a whole lot of time, because - for example - "git add" only completes file names that actually *need* to be staged. So I would be firmly against throwing out Nikolai's hard work. As I was saying in another mail=C2=B9, I was also thinking about a scheme to give the user the option to choose smart (and slow) and utterly-dumb (and quick) file completion in various contexts via zstyle. A boolean style is very quick to look up and wouldn't impact performance. That way, each user could have it his/her way, fine tuned for all git sub-commands. That would be something everyone should be able to live with. Also, improving performance of the existing code would be highly appreciated. Regards, Frank =C2=B9 <87ei4o7p0h.fsf@ft.bewatermyfriend.org>