From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28988 invoked by alias); 5 May 2013 09:47:08 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 31373 Received: (qmail 5300 invoked from network); 5 May 2013 09:46:53 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 Received-SPF: none (ns1.primenet.com.au: domain at bewatermyfriend.org does not designate permitted sender hosts) From: Frank Terbeck To: Zsh hackers list Subject: Re: precmd: write error: interrupted In-Reply-To: (Bart Schaefer's message of "Sat, 4 May 2013 23:52:20 -0700") References: <130425111646.ZM17258@torch.brasslantern.com> <130426080805.ZM18619@torch.brasslantern.com> <517C0E09.4040505@users.sourceforge.net> <130427153141.ZM20125@torch.brasslantern.com> <517D40B0.8020609@thregr.org> <130428180338.ZM14577@torch.brasslantern.com> <8738u2b8gy.fsf@ft.bewatermyfriend.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) Date: Sun, 05 May 2013 11:38:24 +0200 Message-ID: <87y5btahrj.fsf@ft.bewatermyfriend.org> MIME-Version: 1.0 Content-Type: text/plain X-Df-Sender: [pbs]NDMwNDQ0 Bart Schaefer wrote: > On Sat, May 4, 2013 at 5:01 PM, Frank Terbeck wrote: >> I'm afraid these changes break SIGWINCH handling of child processes. > > Not entirely surprising. I wondered about that but tried it with a couple > of apps before posting and they seemed to be responding to the change in > size. I didn't actually test whether they were receiving WINCH, though. > > The below should help, but someone will have to commit it for me, because It does help with normal children (ie. the ones the shell fork()s for). But it doesn't fix cases, in which you use `exec' to replace the shell process with the child process. > the computer with my sourceforge ssh keys suffered a video chip meltdown > yesterday and I haven't had a chance to repair it or pull the key file from > backup yet. For the same reason, I'm composing this in gmail, so I hope > the patch has not been mangled. It was mangled, but is was short enough to apply manually. I've pushed this, because it's definitely an improvement. I tried looking for the right position to unblock SIGWINCH for the `exec' case in exec.c, but couldn't find it yet. Maybe someone has a more specific idea than I do? Regards, Frank