From: Frank Terbeck <ft@bewatermyfriend.org>
To: 654225@bugs.debian.org
Cc: Michael Prokop <mika@debian.org>, mbj@spamcop.net, zsh-workers@zsh.org
Subject: PATCH: Restore `LC_ALL' when setting `LANG'
Date: Tue, 03 Jan 2012 16:26:44 +0100 [thread overview]
Message-ID: <87y5to7qob.fsf@ft.bewatermyfriend.org> (raw)
In-Reply-To: <87boqk95we.fsf@ft.bewatermyfriend.org> (Frank Terbeck's message of "Tue, 03 Jan 2012 16:12:33 +0100")
(Cc:ing Upstream)
When setting LANG, zsh sets LC_ALL and then goes on to restore all
interesting LC_* values after that. Up to now, it did not restore LC_ALL
itself, though.
That could lead to trouble when setting LC_ALL=something-utf8-ish and
after that LANG=something-non-utf8.
This was reported in Debian bugreport #654225:
<http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=654225>
A recipe to reproduce the issue is here:
<http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=654225#65>
I think the patch below fixes the issue correctly, by restoring LC_ALL
from its parameter along the way with all the other LC_* values zsh
cares about.
(FWIW, the test-suite still passes with this change.)
Regards, Frank
---
Src/params.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/Src/params.c b/Src/params.c
index 446cccc..6d98b8e 100644
--- a/Src/params.c
+++ b/Src/params.c
@@ -3780,6 +3780,9 @@ static struct localename {
#ifdef LC_TIME
{"LC_TIME", LC_TIME},
#endif
+#ifdef LC_ALL
+ {"LC_ALL", LC_ALL},
+#endif
{NULL, 0}
};
--
1.7.8.rc3.17.gf56ef1
next parent reply other threads:[~2012-01-03 15:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120102132718.GA12143@gatsby.mbjnet.dk>
[not found] ` <87fwfyb2if.fsf@ft.bewatermyfriend.org>
[not found] ` <20120102154714.GA20663@gatsby.mbjnet.dk>
[not found] ` <87wr9a9ely.fsf@ft.bewatermyfriend.org>
[not found] ` <20120103111049.GA5673@gatsby.mbjnet.dk>
[not found] ` <87sjjw98yl.fsf@ft.bewatermyfriend.org>
[not found] ` <87k458974e.fsf@ft.bewatermyfriend.org>
[not found] ` <2012-01-03T15-59-18@devnull.michael-prokop.at>
[not found] ` <87boqk95we.fsf@ft.bewatermyfriend.org>
2012-01-03 15:26 ` Frank Terbeck [this message]
2012-01-04 2:16 ` Vincent Lefevre
2012-01-04 17:30 ` Peter Stephenson
2012-01-06 6:03 ` Jun T.
2012-01-07 20:04 ` Peter Stephenson
2012-01-07 21:41 ` Frank Terbeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5to7qob.fsf@ft.bewatermyfriend.org \
--to=ft@bewatermyfriend.org \
--cc=654225@bugs.debian.org \
--cc=mbj@spamcop.net \
--cc=mika@debian.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).