From: Torsten Hilbrich <Torsten.Hilbrich@gmx.net>
To: Peter Stephenson <pws@ibmth.df.unipi.it>
Cc: zsh-workers@math.gatech.edu
Subject: Re: Bugreport zsh 3.1.2: Shell exits prematurely after aborting history-incremental-search-backward
Date: 12 Jun 1998 23:41:10 +0200 [thread overview]
Message-ID: <87yav2l2mh.fsf@marvin.bln.de> (raw)
In-Reply-To: Peter Stephenson's message of "Thu, 11 Jun 1998 17:26:04 +0200"
On: Thu, 11 Jun 1998 17:26:04 +0200 Peter Stephenson writes:
> Torsten Hilbrich wrote:
>> If I startup the zsh I immediatly
>> history-incremental-search-backward (^R) in the history. Instead
>> of executing the found command I simply abort using ^C. Then the
>> next return with or without any command given will immediatly exit
>> the shell. It also happens if there is no match found in the
>> backward search.
>
> I had a look at this again, and I believe my previous analysis, that
> the lastc variable wasn't getting set properly, was the correct one.
> This time I followed the problem at bit further back. In my case,
> /etc/zshenv was being sourced immediately before the command loop
> started. At EOF, inputline() returned false; this caused ingetc()
> to set lastc to ' ', the behaviour which I found suspect. Thus the
> first time from zleread(), inerrflush() tested lastc, found it
> wasn't \n, and assumed, wrongly, there was some junk to flush out.
> Knock-on errors from this caused the shell to exit. Later on, lastc
> would be \n because the last input operation was a read from stdin
> which didn't return EOF. (You can get the same behaviour at any time
> by sourcing a file, followed by the actions Torsten described.)
>
> If there was no /etc/zshenv to source, lastc still wouldn't be \n
> because it wasn't initialised, so the same thing happens.
>
> So my patch was correct, with one thing I forgot about: lastc should
> be initialised to \n at startup as a flag that there is no input to
> flush. Here is the complete thing.
> [patch removed]
I just applied the patch and the error is gone. If there are any
side-effects that I notice, I will reply directly to Peter.
Thanks to everyone for your efforts,
Torsten
--
Whenever a system becomes completely defined, some damn fool discovers
something which either abolishes the system or expands it beyond recognition.
Fortune Cookie
PGP Public key available
prev parent reply other threads:[~1998-06-13 15:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
1998-06-01 19:57 Torsten Hilbrich
1998-06-02 15:49 ` Peter Stephenson
1998-06-02 17:41 ` Bart Schaefer
1998-06-03 9:09 ` Peter Stephenson
1998-06-11 15:26 ` Peter Stephenson
1998-06-12 2:58 ` Bart Schaefer
1998-06-12 9:16 ` Peter Stephenson
1998-06-12 15:38 ` Bart Schaefer
1998-06-12 21:41 ` Torsten Hilbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87yav2l2mh.fsf@marvin.bln.de \
--to=torsten.hilbrich@gmx.net \
--cc=pws@ibmth.df.unipi.it \
--cc=zsh-workers@math.gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).