zsh-workers
 help / color / mirror / code / Atom feed
From: Frank Terbeck <ft@bewatermyfriend.org>
To: Nikolai Weibull <now@disu.se>
Cc: Ramkumar Ramachandra <artagnon@gmail.com>,
	 ZSH Workers <zsh-workers@zsh.org>,
	 Clint Adams <clint@users.sourceforge.net>,
	 Frank Terbeck <bewater@users.sourceforge.net>
Subject: Re: [PATCH 2/3] Completion/Unix/Command/_git: fix shortlog completer
Date: Sat, 20 Apr 2013 17:05:03 +0200	[thread overview]
Message-ID: <87zjwt5jkw.fsf@ft.bewatermyfriend.org> (raw)
In-Reply-To: <CADdV=MtT-e8ctrsgmavfFYPzP89h-nAdL9_OOD_rFJvPD=VkSg@mail.gmail.com> (Nikolai Weibull's message of "Sat, 20 Apr 2013 15:03:28 +0200")

Nikolai Weibull wrote:
> On Sat, Apr 20, 2013 at 2:56 PM, Ramkumar Ramachandra
> <artagnon@gmail.com> wrote:
[...]
>> +    (commit-range-or-file)
>
> Perhaps it’s time to add a helper function for this kind of context.

So, do we take this patch as well or do we want to spend time on
fleshing out the helper function? Both would work for me, to be
honest. :)

The other two patches looked good, I think.

Regards, Frank


  reply	other threads:[~2013-04-20 15:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-20 12:56 [PATCH 0/3] Completion/Unix/Command/_git: misc fixes Ramkumar Ramachandra
2013-04-20 12:56 ` [PATCH 1/3] Completion/Unix/Command/_git: add a couple of browsers Ramkumar Ramachandra
2013-04-20 12:56 ` [PATCH 2/3] Completion/Unix/Command/_git: fix shortlog completer Ramkumar Ramachandra
2013-04-20 13:03   ` Nikolai Weibull
2013-04-20 15:05     ` Frank Terbeck [this message]
2013-04-20 17:13       ` Ramkumar Ramachandra
2013-04-20 17:35         ` Bart Schaefer
2013-04-20 17:50           ` Ramkumar Ramachandra
2013-04-25 12:42   ` Frank Terbeck
2013-04-25 13:11     ` Nikolai Weibull
2013-04-25 18:12       ` Ramkumar Ramachandra
2013-04-25 17:48     ` Ramkumar Ramachandra
2013-04-25 19:06       ` Frank Terbeck
2013-04-27  8:56         ` Nikolai Weibull
2013-04-27  9:01           ` Nikolai Weibull
2013-04-28 14:30           ` Nikolai Weibull
2013-05-11 16:55             ` Nikolai Weibull
2013-05-12 17:48               ` Peter Stephenson
2013-04-27 10:22         ` Ramkumar Ramachandra
2013-04-27 11:27           ` Frank Terbeck
2013-04-20 12:56 ` [PATCH 3/3] Completion/Unix/Command/_git: branch.*.pushremote, remote.pushdefault Ramkumar Ramachandra
2013-04-21 10:16 ` [PATCH 0/3] Completion/Unix/Command/_git: misc fixes Frank Terbeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zjwt5jkw.fsf@ft.bewatermyfriend.org \
    --to=ft@bewatermyfriend.org \
    --cc=artagnon@gmail.com \
    --cc=bewater@users.sourceforge.net \
    --cc=clint@users.sourceforge.net \
    --cc=now@disu.se \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).