From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22395 invoked by alias); 20 Apr 2013 15:22:58 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 31291 Received: (qmail 20727 invoked from network); 20 Apr 2013 15:22:47 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_HELO_PASS autolearn=ham version=3.3.2 Received-SPF: none (ns1.primenet.com.au: domain at bewatermyfriend.org does not designate permitted sender hosts) From: Frank Terbeck To: Nikolai Weibull Cc: Ramkumar Ramachandra , ZSH Workers , Clint Adams , Frank Terbeck Subject: Re: [PATCH 2/3] Completion/Unix/Command/_git: fix shortlog completer In-Reply-To: (Nikolai Weibull's message of "Sat, 20 Apr 2013 15:03:28 +0200") References: <1366462573-15545-1-git-send-email-artagnon@gmail.com> <1366462573-15545-3-git-send-email-artagnon@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) Date: Sat, 20 Apr 2013 17:05:03 +0200 Message-ID: <87zjwt5jkw.fsf@ft.bewatermyfriend.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Df-Sender: [pbs]MzQ5NTM4 Nikolai Weibull wrote: > On Sat, Apr 20, 2013 at 2:56 PM, Ramkumar Ramachandra > wrote: [...] >> + (commit-range-or-file) > > Perhaps it=E2=80=99s time to add a helper function for this kind of conte= xt. So, do we take this patch as well or do we want to spend time on fleshing out the helper function? Both would work for me, to be honest. :) The other two patches looked good, I think. Regards, Frank