From: Frank Terbeck <ft@bewatermyfriend.org>
To: "Akinori MUSHA" <knu@iDaemons.org>
Cc: zsh-workers@zsh.org
Subject: Re: PATCH: Update VCS_INFO_detect_svn for Subversion 1.7
Date: Wed, 09 Nov 2011 17:30:54 +0100 [thread overview]
Message-ID: <87zkg5xnpd.fsf@ft.bewatermyfriend.org> (raw)
In-Reply-To: <86sjlxoows.knu@iDaemons.org> (Akinori MUSHA's message of "Wed, 09 Nov 2011 14:17:23 +0900")
It seems like I was missing something Phil put into the `_get_data_'
function: It is able to handle nested working copies. As in: /foo/bar is
the checkout of one repository and /foo/bar/baz/bob being the checkout
of another.
My glob idea doesn't catch that properly.
The matter has been discussed on IRC for a while and I've come to the
conclusion that applying Akinori's original patch is probably the best.
It does double the work a little, but I think it should work in almost
all cases.
So, thanks for that.
Regards, Frank
Akinori MUSHA wrote:
[...]
> Index: Functions/VCS_Info/Backends/VCS_INFO_detect_svn
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Functions/VCS_Info/Backends/VCS_INFO_detect_svn,v
> retrieving revision 1.3
> diff -u -r1.3 VCS_INFO_detect_svn
> --- Functions/VCS_Info/Backends/VCS_INFO_detect_svn 11 Feb 2011 07:05:09 -0000 1.3
> +++ Functions/VCS_Info/Backends/VCS_INFO_detect_svn 9 Nov 2011 05:14:03 -0000
> @@ -7,5 +7,5 @@
> [[ $1 == '--flavours' ]] && return 1
>
> VCS_INFO_check_com ${vcs_comm[cmd]} || return 1
> -{ [[ -f ".svn/entries" ]] || [[ -f ".svn/format" ]] } && return 0
> -return 1
> +vcs_comm[detect_need_file]="entries format"
> +VCS_INFO_bydir_detect '.svn' || return 1
prev parent reply other threads:[~2011-11-09 16:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 5:17 Akinori MUSHA
2011-11-09 12:49 ` Frank Terbeck
2011-11-09 13:58 ` Frank Terbeck
2011-11-09 15:57 ` Bart Schaefer
2011-11-09 16:07 ` Daniel Shahaf
2011-11-09 16:12 ` Jérémie Roquet
2011-11-09 16:30 ` Frank Terbeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zkg5xnpd.fsf@ft.bewatermyfriend.org \
--to=ft@bewatermyfriend.org \
--cc=knu@iDaemons.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).