zsh-workers
 help / color / mirror / code / Atom feed
* merged Makefile fixes
@ 1997-01-02 14:33 Zefram
  1997-01-02 16:18 ` Zoltan Hidvegi
  1997-01-02 18:55 ` Zoltan Hidvegi
  0 siblings, 2 replies; 4+ messages in thread
From: Zefram @ 1997-01-02 14:33 UTC (permalink / raw)
  To: Z Shell workers mailing list

-----BEGIN PGP SIGNED MESSAGE-----

This patch does what my patch 2696 does, but applies on top of Zoltan's
patch 2694.  Please use this *instead of* patch 2696.

This patch also makes sure that the Makefile passes all necessary
parameters to the scripts, and avoids relying on #!.

 -zefram

 *** Src/Makefile.in	Thu Jan  2 13:51:13 1997
 --- Src/Makefile.in	Thu Jan  2 14:19:57 1997
 ***************
 *** 54,60 ****
   DLLDFLAGS = @DLLDFLAGS@
   EXTRA_LDFLAGS = @EXTRA_LDFLAGS@
   
 ! INCLUDES = -I.. -I. -I$(srcdir) -I$(MODULE_DIR) -IZle -I$(srcdir)/Zle
   
   DNCFLAGS =
   
 --- 54,60 ----
   DLLDFLAGS = @DLLDFLAGS@
   EXTRA_LDFLAGS = @EXTRA_LDFLAGS@
   
 ! INCLUDES = -I.. -I. -I$(srcdir)
   
   DNCFLAGS =
   
 ***************
 *** 75,80 ****
 --- 75,82 ----
   prefix='$(prefix)' exec_prefix='$(exec_prefix)' bindir='$(bindir)' \
   libdir='$(libdir)' infodir='$(infodir)' mandir='$(mandir)' manext='$(manext)'
   
 + EXTRA_BUILDACT = :
 + 
   KNR_OBJ=.o
   KNROBJ=._foo_
   
 ***************
 *** 86,96 ****
 --- 88,100 ----
   
   .c$(ANSI@U@OBJ):
   	$(COMPILE) -o $@ $<
 + 	@$(EXTRA_BUILDACT)
   
   .c$(KNR@U@OBJ):
   	./ansi2knr $< > $@.c
   	$(COMPILE) -o $@ $@.c
   	rm -f $@.c
 + 	@$(EXTRA_BUILDACT)
   
   .c.pro:
   	$(SED) -n -f $(srcdir)/makepro.sed $< > $@
 ***************
 *** 154,160 ****
   XMODCF  = $(srcdir)/xmods.conf
   MODBINS = modules-bltin
   
 ! CFSED   = sed -n -f $(srcdir)/conf.sed -e
   
   # ========= DEPENDENCIES FOR BUILDING ==========
   
 --- 158,164 ----
   XMODCF  = $(srcdir)/xmods.conf
   MODBINS = modules-bltin
   
 ! CFSED   = -f $(srcdir)/conf.sed
   
   # ========= DEPENDENCIES FOR BUILDING ==========
   
 ***************
 *** 208,221 ****
   	fi
   
   bltinmods.list: $(MODBINS) $(XMODCF) mkbltnmlst.sh
 ! 	MODBINS=$(MODBINS) XMODCF=$(XMODCF) $(srcdir)/mkbltnmlst.sh $@
   
   zshxmods.h: $(MODBINS) $(XMODCF)
   	@echo "Creating \`$@'."
   	@( \
   	    binmods=`sed 's/^/ /;s/$$/ /' $(MODBINS)`; \
 ! 	    sed='/^[^#:>]*>[^#:>]*$$/{s/>.*//;p;}'; \
 ! 	    xmods=`$(CFSED) "$$sed" $(XMODCF)`; \
   	    for mod in $$xmods; do \
   		case $$binmods in \
   		    *" $$mod "*) \
 --- 212,229 ----
   	fi
   
   bltinmods.list: $(MODBINS) $(XMODCF) mkbltnmlst.sh
 ! 	srcdir='$(srcdir)'; \
 ! 	CFSED='$(CFSED)'; \
 ! 	MODBINS='$(MODBINS)'; \
 ! 	XMODCF='$(XMODCF)'; \
 ! 	. $(srcdir)/mkbltnmlst.sh $@
   
   zshxmods.h: $(MODBINS) $(XMODCF)
   	@echo "Creating \`$@'."
   	@( \
   	    binmods=`sed 's/^/ /;s/$$/ /' $(MODBINS)`; \
 ! 	    sed='/^[^:>]*>[^:>]*$$/{s/>.*//;p;}'; \
 ! 	    xmods=`sed -n $(CFSED) -e "$$sed" $(XMODCF)`; \
   	    for mod in $$xmods; do \
   		case $$binmods in \
   		    *" $$mod "*) \
 ***************
 *** 231,237 ****
   
   $(MODBINS):
   	if test @D@ = N; then \
 ! 	    $(CFSED) '/^[^#:>]*>[^#:>]*$$/{s/>.*//;p;}' $(XMODCF) > $@; \
   	else \
   	    echo > $@; \
   	fi
 --- 239,245 ----
   
   $(MODBINS):
   	if test @D@ = N; then \
 ! 	    sed -n $(CFSED) -e '/^[^:>]*>[^:>]*$$/{s/>.*//;p;}' $(XMODCF) > $@; \
   	else \
   	    echo > $@; \
   	fi
 ***************
 *** 241,248 ****
   $(PROTO): makepro.sed
   
   $(NSTMP): $(MODBINS) $(MODCF) mkstamp.sh proto FORCE
 ! 	@MODBINS=$(MODBINS) MODCF=$(MODCF) MODULE_DIRS="$(MODULE_DIRS)" \
 ! 	MAKE=$(MAKE) MAKEDEFS="$(MAKEDEFS)" $(srcdir)/mkstamp.sh $@
   
   FORCE:
   
 --- 249,262 ----
   $(PROTO): makepro.sed
   
   $(NSTMP): $(MODBINS) $(MODCF) mkstamp.sh proto FORCE
 ! 	@srcdir='$(srcdir)'; \
 ! 	CFSED='$(CFSED)'; \
 ! 	MODBINS='$(MODBINS)'; \
 ! 	MODCF='$(MODCF)'; \
 ! 	MODULE_DIRS='$(MODULE_DIRS)'; \
 ! 	MAKE='$(MAKE)'; \
 ! 	MAKEDEFS="$(MAKEDEFS)"; \
 ! 	. $(srcdir)/mkstamp.sh $@
   
   FORCE:
   
 *** Src/conf.sed	Thu Jan  2 13:51:13 1997
 --- Src/conf.sed	Thu Jan  2 13:57:43 1997
 ***************
 *** 5,8 ****
       b1
   }
   s/	/ /g
 ! /^ *$$/d
 --- 5,9 ----
       b1
   }
   s/	/ /g
 ! s/#.*$//
 ! /^ *$/d
 *** Src/mkbltnmlst.sh	Thu Jan  2 13:51:13 1997
 --- Src/mkbltnmlst.sh	Thu Jan  2 14:14:17 1997
 ***************
 *** 4,20 ****
   #
   # Written by Andrew Main
   #
 ! srcdir=`echo $0|sed 's%/[^/][^/]*$%%'`
 ! test "x$srcdir" = "x$0" && srcdir=.
 ! CFSED="${CFSED-sed -n -f $srcdir/conf.sed -e}"
 ! MODBINS="${MODBINS-modules-bltin}"
 ! XMODCF="${XMODCF-$srcdir/xmods.conf}"
   binmods=`sed 's/^/ /;s/$/ /' $MODBINS`
 ! sed='/^[^#:>]*>[^#:>]*$/{
       s/>.*//
       p
   }'
 ! xmods=`$CFSED "$sed" $XMODCF`
   trap "rm -f $1; exit 1" 1 2 15
   exec > $1
   for mod in $xmods; do
 --- 4,20 ----
   #
   # Written by Andrew Main
   #
 ! srcdir=${srcdir:-`echo $0|sed 's%/[^/][^/]*$%%'`}
 ! srcdir=${srcdir:-.}
 ! CFSED=${CFSED-"-f $srcdir/conf.sed"}
 ! MODBINS=${MODBINS-modules-bltin}
 ! XMODCF=${XMODCF-$srcdir/xmods.conf}
   binmods=`sed 's/^/ /;s/$/ /' $MODBINS`
 ! sed='/^[^:>]*>[^:>]*$/{
       s/>.*//
       p
   }'
 ! xmods=`sed -n $CFSED -e "$sed" $XMODCF`
   trap "rm -f $1; exit 1" 1 2 15
   exec > $1
   for mod in $xmods; do
 ***************
 *** 21,39 ****
       case $binmods in
   	*" $mod "*) ;;
   	*)  echo "/* non-linked-in known module \`$mod' */"
 ! 	    sed='/^ *'$mod' *>[^#:>]*$/{
                       s/.*>//
                       p
                    }'
 ! 	    bins=`$CFSED "$sed" $XMODCF`
   	    for bin in $bins; do
   		echo "    add_autobin(\"$bin\", \"$mod\");"
   	    done
 ! 	    sed='/^ *'$mod' *:[^#:>]*$/{
                        s/.*://
                        p
                    }'
 ! 	    deps=`$CFSED "$sed" $XMODCF`
   	    for dep in $deps; do
   		case $binmods in
   		    *" $dep "*)
 --- 21,39 ----
       case $binmods in
   	*" $mod "*) ;;
   	*)  echo "/* non-linked-in known module \`$mod' */"
 ! 	    sed='/^ *'$mod' *>[^:>]*$/{
                       s/.*>//
                       p
                    }'
 ! 	    bins=`sed -n $CFSED -e "$sed" $XMODCF`
   	    for bin in $bins; do
   		echo "    add_autobin(\"$bin\", \"$mod\");"
   	    done
 ! 	    sed='/^ *'$mod' *:[^:>]*$/{
                        s/.*://
                        p
                    }'
 ! 	    deps=`sed -n $CFSED -e "$sed" $XMODCF`
   	    for dep in $deps; do
   		case $binmods in
   		    *" $dep "*)
 ***************
 *** 47,57 ****
   donemods=" "
   for mod in $binmods; do
       echo "/* linked-in module \`$mod' */"
 !     sed='/^ *'$mod' *:[^#:>]*$/{
                s/.*://
                p
            }'
 !     deps=`$CFSED "$sed" $XMODCF`
       for dep in $deps; do
   	case $donemods in
   	    *" $dep "*)
 --- 47,57 ----
   donemods=" "
   for mod in $binmods; do
       echo "/* linked-in module \`$mod' */"
 !     sed='/^ *'$mod' *:[^:>]*$/{
                s/.*://
                p
            }'
 !     deps=`sed -n $CFSED -e "$sed" $XMODCF`
       for dep in $deps; do
   	case $donemods in
   	    *" $dep "*)
 *** Src/mkstamp.sh	Thu Jan  2 13:51:13 1997
 --- Src/mkstamp.sh	Thu Jan  2 14:30:07 1997
 ***************
 *** 4,28 ****
   #
   # Written by Andrew Main
   #
 ! srcdir=`echo $0|sed 's%/[^/][^/]*$%%'`
 ! test "x$srcdir" = "x$0" && srcdir=.
 ! CFSED=${CFSED-"sed -n -f $srcdir/conf.sed -e"}
   MODBINS=${MODBINS-modules-bltin}
   MODCF=${MODCF-$srcdir/mods.conf}
 ! MODULE_DIRS=${MODULE_DIRS-'Modules Zle'}
   MAKE=${MAKE-make}
   STMP=$1
   
 ! dn=true
 ! test -f $STMP || dn=false
   trap "rm -f $STMP.tmp; exit 1" 1 2 15
   echo > $STMP.tmp
   for mod in `cat $MODBINS`; do
 !     sed='/^ *'$mod' *:[^#:>]*$/{
                s/.*://
                p
            }'
 !     objs=`$CFSED "$sed" $MODCF`
       if test -z "$objs"; then
   	for dir in $MODULE_DIRS; do
   	    if test -f $srcdir/$dir/$mod.c; then
 --- 4,27 ----
   #
   # Written by Andrew Main
   #
 ! srcdir=${srcdir:-`echo $0|sed 's%/[^/][^/]*$%%'`}
 ! srcdir=${srcdir:-.}
 ! CFSED=${CFSED-"-f $srcdir/conf.sed"}
   MODBINS=${MODBINS-modules-bltin}
   MODCF=${MODCF-$srcdir/mods.conf}
 ! MODULE_DIRS=${MODULE_DIRS-Modules Zle}
   MAKE=${MAKE-make}
   STMP=$1
   
 ! act="rm -f `pwd`/$STMP"
   trap "rm -f $STMP.tmp; exit 1" 1 2 15
   echo > $STMP.tmp
   for mod in `cat $MODBINS`; do
 !     sed='/^ *'$mod' *:[^:>]*$/{
                s/.*://
                p
            }'
 !     objs=`sed -n $CFSED -e "$sed" $MODCF`
       if test -z "$objs"; then
   	for dir in $MODULE_DIRS; do
   	    if test -f $srcdir/$dir/$mod.c; then
 ***************
 *** 37,54 ****
   	    exit 1
   	fi
       fi
 !     eval "$MAKE $MAKEDEFS $objs" || { rm -f $STMP.tmp; exit 1; }
 !     if test $dn = true; then
 ! 	nobjs=`find . -name '*.o' -newer $STMP -print`
 ! 	for obj in $objs; do
 ! 	    case $nobjs in
 ! 		*./$obj*) dn=false ;;
 ! 	    esac
 ! 	done
 !     fi
       echo $objs >> $STMP.tmp
   done
 ! if $dn && cmp -s $STMP.tmp $STMP; then
       rm -f $STMP.tmp
       echo "\`$STMP' is up to date."
   else
 --- 36,48 ----
   	    exit 1
   	fi
       fi
 !     bdir=`echo $objs | sed 's, .*$,,;s,^,./,;s,/[^/]*$,,'`
 !     bobjs=`echo '' $objs | sed 's, [^ ]*/, ,g'`
 !     ( cd $bdir && eval "$MAKE $MAKEDEFS EXTRA_BUILDACT=\"\$act\" \$bobjs" ||
 ! 	{ rm -f $STMP.tmp; exit 1; } )
       echo $objs >> $STMP.tmp
   done
 ! if cmp -s $STMP.tmp $STMP; then
       rm -f $STMP.tmp
       echo "\`$STMP' is up to date."
   else
 *** Src/mods.conf	Thu Jan  2 13:50:29 1997
 --- Src/mods.conf	Thu Jan  2 13:58:37 1997
 ***************
 *** 13,20 ****
   # Each entry has the form:
   #     module_name : Dir/object.o ...
   #
 ! # Lines containing `#' *anywhere* are ignored, as are blank lines.  Lines may
 ! # be continued using the usual backslash/newline syntax.
   #
   # (This would be rather neater if we could rely on shell functions in sh.)
   #
 --- 13,20 ----
   # Each entry has the form:
   #     module_name : Dir/object.o ...
   #
 ! # `#' starts a comment, and blank lines are ignored.  Lines may be continued
 ! # using the usual backslash/newline syntax.
   #
   # (This would be rather neater if we could rely on shell functions in sh.)
   #
 *** Src/xmods.conf	Thu Jan  2 13:50:29 1997
 --- Src/xmods.conf	Thu Jan  2 13:58:46 1997
 ***************
 *** 18,25 ****
   # is linked in, the other modules must also be, and must be listed earlier in
   # modules-bltin (and, consequently, here).
   #
 ! # Lines containing `#' *anywhere* are ignored, as are blank lines.  Lines may
 ! # be continued using the usual backslash/newline syntax.
   #
   # (This would be rather neater if we could rely on shell functions in sh.)
   #
 --- 18,25 ----
   # is linked in, the other modules must also be, and must be listed earlier in
   # modules-bltin (and, consequently, here).
   #
 ! # `#' starts a comment, and blank lines are ignored.  Lines may be continued
 ! # using the usual backslash/newline syntax.
   #
   # (This would be rather neater if we could rely on shell functions in sh.)
   #
 *** Src/Modules/Makefile.in	Thu Jan  2 13:50:27 1997
 --- Src/Modules/Makefile.in	Thu Jan  2 13:59:34 1997
 ***************
 *** 64,69 ****
 --- 64,71 ----
   
   SED = sed
   
 + EXTRA_BUILDACT = :
 + 
   KNR_OBJ=.o
   KNROBJ=._foo_
   
 ***************
 *** 75,85 ****
 --- 77,89 ----
   
   .c$(ANSI@U@OBJ):
   	$(COMPILE) -o $@ $<
 + 	@$(EXTRA_BUILDACT)
   
   .c$(KNR@U@OBJ):
   	../ansi2knr $< > $@.c
   	$(COMPILE) -o $@ $@.c
   	rm -f $@.c
 + 	@$(EXTRA_BUILDACT)
   
   .c.$(ANSI@U@OBJ):
   	$(DLCOMPILE) -o $@ $<
 *** Src/Zle/Makefile.in	Thu Jan  2 13:50:27 1997
 --- Src/Zle/Makefile.in	Thu Jan  2 13:59:54 1997
 ***************
 *** 63,68 ****
 --- 63,70 ----
   
   SED = sed
   
 + EXTRA_BUILDACT = :
 + 
   KNR_OBJ=.o
   KNROBJ=._foo_
   
 ***************
 *** 74,84 ****
 --- 76,88 ----
   
   .c$(ANSI@U@OBJ):
   	$(COMPILE) -o $@ $<
 + 	@$(EXTRA_BUILDACT)
   
   .c$(KNR@U@OBJ):
   	../ansi2knr $< > $@.c
   	$(COMPILE) -o $@ $@.c
   	rm -f $@.c
 + 	@$(EXTRA_BUILDACT)
   
   .c.$(ANSI@U@OBJ):
   	$(DLCOMPILE) -o $@ $<

-----BEGIN PGP SIGNATURE-----
Version: 2.6.3i
Charset: ascii

iQCVAwUBMsvG9nD/+HJTpU/hAQFbswQAjioU5WKQvrvNvlJwbBJ2ftb8KC37q7K0
+isycO4BZ9lNYEBKBjAsRo2Wrw3DzzRI7pMaFAMcMusso354OSuAGX8V6I4fzrEH
M8fdjD2kyoB59OwHiHoPFz4JWluPlbct1m0Lw04Ere9/1Y41YElwYNvlLeQ6eccU
xaYlWfZZ0Sw=
=PqLS
-----END PGP SIGNATURE-----


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: merged Makefile fixes
  1997-01-02 14:33 merged Makefile fixes Zefram
@ 1997-01-02 16:18 ` Zoltan Hidvegi
  1997-01-02 18:55 ` Zoltan Hidvegi
  1 sibling, 0 replies; 4+ messages in thread
From: Zoltan Hidvegi @ 1997-01-02 16:18 UTC (permalink / raw)
  To: Zefram; +Cc: zsh-workers

Zefram wrote:
> This patch does what my patch 2696 does, but applies on top of Zoltan's
> patch 2694.  Please use this *instead of* patch 2696.

And after that also apply the patch below.  ${...:-...} is not supported by
old shells.  It alse moves an exit out from a subshell.

Zoltan


diff -c Src/mkbltnmlst.sh.zefram Src/mkbltnmlst.sh
*** Src/mkbltnmlst.sh.zefram	Thu Jan  2 16:14:57 1997
--- Src/mkbltnmlst.sh	Thu Jan  2 16:32:18 1997
***************
*** 4,11 ****
  #
  # Written by Andrew Main
  #
! srcdir=${srcdir:-`echo $0|sed 's%/[^/][^/]*$%%'`}
! srcdir=${srcdir:-.}
  CFSED=${CFSED-"-f $srcdir/conf.sed"}
  MODBINS=${MODBINS-modules-bltin}
  XMODCF=${XMODCF-$srcdir/xmods.conf}
--- 4,12 ----
  #
  # Written by Andrew Main
  #
! srcdir=${srcdir-`echo $0|sed 's%/[^/][^/]*$%%'`}
! test "x$srcdir" = "x$0" && srcdir=.
! test "x$srcdir" = "x"   && srcdir=.
  CFSED=${CFSED-"-f $srcdir/conf.sed"}
  MODBINS=${MODBINS-modules-bltin}
  XMODCF=${XMODCF-$srcdir/xmods.conf}
diff -c Src/mkstamp.sh.zefram Src/mkstamp.sh
*** Src/mkstamp.sh.zefram	Thu Jan  2 15:58:47 1997
--- Src/mkstamp.sh	Thu Jan  2 16:32:15 1997
***************
*** 4,15 ****
  #
  # Written by Andrew Main
  #
! srcdir=${srcdir:-`echo $0|sed 's%/[^/][^/]*$%%'`}
! srcdir=${srcdir:-.}
  CFSED=${CFSED-"-f $srcdir/conf.sed"}
  MODBINS=${MODBINS-modules-bltin}
  MODCF=${MODCF-$srcdir/mods.conf}
! MODULE_DIRS=${MODULE_DIRS-Modules Zle}
  MAKE=${MAKE-make}
  STMP=$1
  
--- 4,16 ----
  #
  # Written by Andrew Main
  #
! srcdir=${srcdir-`echo $0|sed 's%/[^/][^/]*$%%'`}
! test "x$srcdir" = "x$0" && srcdir=.
! test "x$srcdir" = "x"   && srcdir=.
  CFSED=${CFSED-"-f $srcdir/conf.sed"}
  MODBINS=${MODBINS-modules-bltin}
  MODCF=${MODCF-$srcdir/mods.conf}
! MODULE_DIRS=${MODULE_DIRS-'Modules Zle'}
  MAKE=${MAKE-make}
  STMP=$1
  
***************
*** 38,45 ****
      fi
      bdir=`echo $objs | sed 's, .*$,,;s,^,./,;s,/[^/]*$,,'`
      bobjs=`echo '' $objs | sed 's, [^ ]*/, ,g'`
!     ( cd $bdir && eval "$MAKE $MAKEDEFS EXTRA_BUILDACT=\"\$act\" \$bobjs" ||
! 	{ rm -f $STMP.tmp; exit 1; } )
      echo $objs >> $STMP.tmp
  done
  if cmp -s $STMP.tmp $STMP; then
--- 39,46 ----
      fi
      bdir=`echo $objs | sed 's, .*$,,;s,^,./,;s,/[^/]*$,,'`
      bobjs=`echo '' $objs | sed 's, [^ ]*/, ,g'`
!     (cd $bdir && eval "$MAKE $MAKEDEFS EXTRA_BUILDACT=\"\$act\" \$bobjs") ||
! 	{ rm -f $STMP.tmp; exit 1; }
      echo $objs >> $STMP.tmp
  done
  if cmp -s $STMP.tmp $STMP; then


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: merged Makefile fixes
  1997-01-02 14:33 merged Makefile fixes Zefram
  1997-01-02 16:18 ` Zoltan Hidvegi
@ 1997-01-02 18:55 ` Zoltan Hidvegi
  1997-01-03 11:02   ` Zefram
  1 sibling, 1 reply; 4+ messages in thread
From: Zoltan Hidvegi @ 1997-01-02 18:55 UTC (permalink / raw)
  To: Zefram; +Cc: zsh-workers

Zefram wrote:
> This patch also makes sure that the Makefile passes all necessary
> parameters to the scripts, and avoids relying on #!.

And it also assumes that the `.' builtin set positional parameters.
Fix included below.

Zoltan


*** Src/Makefile.in	1997/01/02 16:28:02	3.1.1.17
--- Src/Makefile.in	1997/01/02 18:50:24
***************
*** 212,222 ****
  	fi
  
  bltinmods.list: $(MODBINS) $(XMODCF) mkbltnmlst.sh
! 	srcdir='$(srcdir)'; \
! 	CFSED='$(CFSED)'; \
! 	MODBINS='$(MODBINS)'; \
! 	XMODCF='$(XMODCF)'; \
! 	. $(srcdir)/mkbltnmlst.sh $@
  
  zshxmods.h: $(MODBINS) $(XMODCF)
  	@echo "Creating \`$@'."
--- 212,219 ----
  	fi
  
  bltinmods.list: $(MODBINS) $(XMODCF) mkbltnmlst.sh
! 	srcdir='$(srcdir)' CFSED='$(CFSED)' MODBINS='$(MODBINS)' \
! 	XMODCF='$(XMODCF)' $(SHELL) $(srcdir)/mkbltnmlst.sh $@
  
  zshxmods.h: $(MODBINS) $(XMODCF)
  	@echo "Creating \`$@'."
***************
*** 249,262 ****
  $(PROTO): makepro.sed
  
  $(NSTMP): $(MODBINS) $(MODCF) mkstamp.sh proto FORCE
! 	@srcdir='$(srcdir)'; \
! 	CFSED='$(CFSED)'; \
! 	MODBINS='$(MODBINS)'; \
! 	MODCF='$(MODCF)'; \
! 	MODULE_DIRS='$(MODULE_DIRS)'; \
! 	MAKE='$(MAKE)'; \
! 	MAKEDEFS="$(MAKEDEFS)"; \
! 	. $(srcdir)/mkstamp.sh $@
  
  FORCE:
  
--- 246,254 ----
  $(PROTO): makepro.sed
  
  $(NSTMP): $(MODBINS) $(MODCF) mkstamp.sh proto FORCE
! 	@srcdir='$(srcdir)' CFSED='$(CFSED)' MODBINS='$(MODBINS)' \
! 	MODCF='$(MODCF)' MODULE_DIRS='$(MODULE_DIRS)' MAKE='$(MAKE)' \
! 	MAKEDEFS="$(MAKEDEFS)" $(SHELL) $(srcdir)/mkstamp.sh $@
  
  FORCE:
  


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: merged Makefile fixes
  1997-01-02 18:55 ` Zoltan Hidvegi
@ 1997-01-03 11:02   ` Zefram
  0 siblings, 0 replies; 4+ messages in thread
From: Zefram @ 1997-01-03 11:02 UTC (permalink / raw)
  To: Zoltan Hidvegi; +Cc: Z Shell workers mailing list

-----BEGIN PGP SIGNED MESSAGE-----

Zoltan Hidvegi wrote:
>And it also assumes that the `.' builtin set positional parameters.

I noticed that problem too.

>! 	srcdir='$(srcdir)' CFSED='$(CFSED)' MODBINS='$(MODBINS)' \
>! 	XMODCF='$(XMODCF)' $(SHELL) $(srcdir)/mkbltnmlst.sh $@

I think my solution is more readable.  (It is also marginally more
efficient.)

 -zefram

 *** Src/Makefile.in	1997/01/02 20:19:15	1.33
 --- Src/Makefile.in	1997/01/03 05:21:17
 ***************
 *** 212,222 ****
   	fi
   
   bltinmods.list: $(MODBINS) $(XMODCF) mkbltnmlst.sh
   	srcdir='$(srcdir)'; \
   	CFSED='$(CFSED)'; \
   	MODBINS='$(MODBINS)'; \
   	XMODCF='$(XMODCF)'; \
 ! 	. $(srcdir)/mkbltnmlst.sh $@
   
   zshxmods.h: $(MODBINS) $(XMODCF)
   	@echo "Creating \`$@'."
 --- 212,223 ----
   	fi
   
   bltinmods.list: $(MODBINS) $(XMODCF) mkbltnmlst.sh
 + 	TARGET='$@'; \
   	srcdir='$(srcdir)'; \
   	CFSED='$(CFSED)'; \
   	MODBINS='$(MODBINS)'; \
   	XMODCF='$(XMODCF)'; \
 ! 	. $(srcdir)/mkbltnmlst.sh
   
   zshxmods.h: $(MODBINS) $(XMODCF)
   	@echo "Creating \`$@'."
 ***************
 *** 249,262 ****
   $(PROTO): makepro.sed
   
   $(NSTMP): $(MODBINS) $(MODCF) mkstamp.sh proto FORCE
 ! 	@srcdir='$(srcdir)'; \
   	CFSED='$(CFSED)'; \
   	MODBINS='$(MODBINS)'; \
   	MODCF='$(MODCF)'; \
   	MODULE_DIRS='$(MODULE_DIRS)'; \
   	MAKE='$(MAKE)'; \
   	MAKEDEFS="$(MAKEDEFS)"; \
 ! 	. $(srcdir)/mkstamp.sh $@
   
   FORCE:
   
 --- 250,264 ----
   $(PROTO): makepro.sed
   
   $(NSTMP): $(MODBINS) $(MODCF) mkstamp.sh proto FORCE
 ! 	@TARGET='$@'; \
 ! 	srcdir='$(srcdir)'; \
   	CFSED='$(CFSED)'; \
   	MODBINS='$(MODBINS)'; \
   	MODCF='$(MODCF)'; \
   	MODULE_DIRS='$(MODULE_DIRS)'; \
   	MAKE='$(MAKE)'; \
   	MAKEDEFS="$(MAKEDEFS)"; \
 ! 	. $(srcdir)/mkstamp.sh
   
   FORCE:
   
 *** Src/mkbltnmlst.sh	1997/01/02 20:20:44	1.3
 --- Src/mkbltnmlst.sh	1997/01/03 05:20:40
 ***************
 *** 4,9 ****
 --- 4,10 ----
   #
   # Written by Andrew Main
   #
 + TARGET=${TARGET-bltinmods.list}
   srcdir=${srcdir-`echo $0|sed 's%/[^/][^/]*$%%'`}
   test "x$srcdir" = "x$0" && srcdir=.
   test "x$srcdir" = "x"   && srcdir=.
 ***************
 *** 16,23 ****
       p
   }'
   xmods=`sed -n $CFSED -e "$sed" $XMODCF`
 ! trap "rm -f $1; exit 1" 1 2 15
 ! exec > $1
   for mod in $xmods; do
       case $binmods in
   	*" $mod "*) ;;
 --- 17,24 ----
       p
   }'
   xmods=`sed -n $CFSED -e "$sed" $XMODCF`
 ! trap 'rm -f "$TARGET"; exit 1' 1 2 15
 ! exec > "$TARGET"
   for mod in $xmods; do
       case $binmods in
   	*" $mod "*) ;;
 ***************
 *** 58,64 ****
   	    *" $dep "*)
   		echo "    /* depends on \`$dep' */" ;;
   	    *)	echo >&2 "ERROR: linked-in module \`$mod' depends on \`$dep'"
 ! 		rm -f $1
   		exit 1 ;;
   	esac
       done
 --- 59,65 ----
   	    *" $dep "*)
   		echo "    /* depends on \`$dep' */" ;;
   	    *)	echo >&2 "ERROR: linked-in module \`$mod' depends on \`$dep'"
 ! 		rm -f "$TARGET"
   		exit 1 ;;
   	esac
       done
 *** Src/mkstamp.sh	1997/01/02 20:20:44	1.3
 --- Src/mkstamp.sh	1997/01/03 05:22:17
 ***************
 *** 4,9 ****
 --- 4,10 ----
   #
   # Written by Andrew Main
   #
 + TARGET=${TARGET-stamp-modobjs}
   srcdir=${srcdir-`echo $0|sed 's%/[^/][^/]*$%%'`}
   test "x$srcdir" = "x$0" && srcdir=.
   test "x$srcdir" = "x"   && srcdir=.
 ***************
 *** 12,18 ****
   MODCF=${MODCF-$srcdir/mods.conf}
   MODULE_DIRS=${MODULE_DIRS-'Modules Zle'}
   MAKE=${MAKE-make}
 ! STMP=$1
   
   act="rm -f `pwd`/$STMP"
   trap "rm -f $STMP.tmp; exit 1" 1 2 15
 --- 13,19 ----
   MODCF=${MODCF-$srcdir/mods.conf}
   MODULE_DIRS=${MODULE_DIRS-'Modules Zle'}
   MAKE=${MAKE-make}
 ! STMP=$TARGET
   
   act="rm -f `pwd`/$STMP"
   trap "rm -f $STMP.tmp; exit 1" 1 2 15

-----BEGIN PGP SIGNATURE-----
Version: 2.6.3i
Charset: ascii

iQCVAwUBMsznH3D/+HJTpU/hAQFJ8AQAkxGOv29Ei4HZ7mnsJC2GEKWVtFW3BCp4
PgcczT21h6BPSkP1HWSiBVxChZzovs1Ufe7P5wBeZ+hsq+97RqzMlk7g80kN2ue+
kT92HeZ/FWM6GSYkvIi+PIYNFjU++Eqj9g2roZPRFONWE0wbLuV3p9b/igDl2KBR
4lnQ4GA9FEc=
=j8CR
-----END PGP SIGNATURE-----


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~1997-01-03 10:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1997-01-02 14:33 merged Makefile fixes Zefram
1997-01-02 16:18 ` Zoltan Hidvegi
1997-01-02 18:55 ` Zoltan Hidvegi
1997-01-03 11:02   ` Zefram

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).