zsh-workers
 help / color / mirror / code / Atom feed
From: Marlon Richert <marlon.richert@gmail.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] Add -L to add-(zsh|zle)-hook[-widget] completion
Date: Wed, 21 Apr 2021 08:59:22 +0300	[thread overview]
Message-ID: <880D5B7E-6ABE-4325-BFAB-C3593612608B@gmail.com> (raw)
In-Reply-To: <20210420213601.GC1035@tarpaulin.shahaf.local2>

On 21 Apr 2021, at 00:36, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> 
>> From 8b0221296db36c4d55d1b99577886f72afd76d3b Mon Sep 17 00:00:00 2001
>> From: Marlon Richert <marlon.richert@gmail.com>
>> Date: Mon, 19 Apr 2021 20:24:36 +0300
>> Subject: [PATCH] Add -L to add-(zsh|zle)-hook[-widget] completion
> 
> The patch has already been merged, but still:
> 
> Symbols names should be able to be grepped for, so please don't hide
> them behind glob patterns.

Ah, you mean in the commit message? Fair enough. I was just trying to keep the first line of the commit message to 50 characters or less, in line with [Git’s recommendations](https://book.git-scm.com/docs/git-commit#_discussion). But point taken; I will spell it out next time, if not in the first line, then at least in an additional line.

In any case, Oliver did add the exact function names to Changelog:

diff --git a/ChangeLog b/ChangeLog
index 7cf9ec4e5..079b92d32 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,9 @@
 2021-04-19  Oliver Kiddle  <opk@zsh.org>
 
+   * Marlon Richert: 48621: Completion/Zsh/Function/_add-zsh-hook,
+   Completion/Zsh/Function/_add-zle-hook-widget: Add -L to
+   add-(zsh|zle)-hook[-widget] completion
+
        * André Kugland: github/zsh-completions #792:
        Completion/Unix/Command/_opustools: new opus-tools completion
 



  reply	other threads:[~2021-04-21  5:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-19 17:29 Marlon Richert
2021-04-20 21:36 ` Daniel Shahaf
2021-04-21  5:59   ` Marlon Richert [this message]
2021-04-21 20:01     ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=880D5B7E-6ABE-4325-BFAB-C3593612608B@gmail.com \
    --to=marlon.richert@gmail.com \
    --cc=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).