zsh-workers
 help / color / mirror / code / Atom feed
From: Jun T <takimoto-j@kba.biglobe.ne.jp>
To: zsh-workers@zsh.org
Subject: Re: Y01 Test Failure on Arch
Date: Tue, 6 Apr 2021 13:23:23 +0900	[thread overview]
Message-ID: <89AC4C5F-AF90-4A01-B0AD-F2326D28F132@kba.biglobe.ne.jp> (raw)
In-Reply-To: <CAHLkEDuSrpd2UitrjfscP_Kr5xBt+nXCp8enpyAopbY-G3HDmQ@mail.gmail.com>


> 2021/04/05 23:58, Marlon Richert <marlon.richert@gmail.com> wrote:
> 
> On Sun, Apr 4, 2021 at 8:02 PM Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
>> Marlon, the failure is due to workers/48214, which is yours.  Thoughts?
> 
> My original patch included the necessary changes to `comptest` to make
> the tests work correctly. See
> https://www.zsh.org/mla/workers/2021/msg00427.html (relevant part
> included below). However, when I now do `git show
> 07a30613f0b0a5b782d30dbeb46df8382f8a4e2a`, it appears that Oliver left
> those out of the actual commit.

Aha!
It was a mystery for me how you could run Y01 successfully.
Sorry for not going back to your original post.
I believe Oliver was just too busy when committing the patch.

But the test still fails as follows:

--- /tmp/zsh.ztst.34237/ztst.out	2021-04-06 13:06:20.000000000 +0900
+++ /tmp/zsh.ztst.34237/ztst.tout	2021-04-06 13:06:20.000000000 +0900
@@ -8,9 +8,9 @@
 NO:{dir1 dir2 file1 file2}
 DESCRIPTION:{original}
 NO:{*}
-line: {: dir1/}{}
 line: {: dir2/}{}
 line: {: file1 }{}
 line: {: file2 }{}
 line: {: dir1 dir2 file1 file2 }{}
 line: {: *}{}
+line: {: dir1/}{}
Test ./Y01completion.ztst failed: output differs from expected as shown above for:
  comptest $': *\t\t\t\t\t\t\t'
Was testing: _expand shows file types
./Y01completion.ztst: test failed.

Can you reproduce this?
Is it OK to replace "comptest $': *\t\t\t\t\t\t\t'" by "comptest $': *\t'"
as in my patch in workers/48363⁩?

  reply	other threads:[~2021-04-06  4:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-31 13:40 Vin Shelton
2021-04-01  4:05 ` Jun T
2021-04-03 11:32   ` Vin Shelton
2021-04-04  4:05     ` Jun. T
2021-04-04 14:00       ` Vin Shelton
2021-04-04 17:02         ` Daniel Shahaf
2021-04-05 14:58           ` Marlon Richert
2021-04-06  4:23             ` Jun T [this message]
2021-04-06 11:38               ` Marlon
2021-04-06  9:53             ` Oliver Kiddle
2021-04-04 18:27         ` Bart Schaefer
2021-04-05  0:39           ` Vin Shelton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89AC4C5F-AF90-4A01-B0AD-F2326D28F132@kba.biglobe.ne.jp \
    --to=takimoto-j@kba.biglobe.ne.jp \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).