zsh-workers
 help / color / mirror / code / Atom feed
From: Samy Dulor <samy.dulor@orange.fr>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-workers@zsh.org
Subject: Re: [BUG] complist interactive mode overwrites command line
Date: Mon, 4 Mar 2024 12:30:08 +0100	[thread overview]
Message-ID: <8a90a759-2853-b6e1-8d9b-5824afbc8f47@orange.fr> (raw)
In-Reply-To: <CAH+w=7ZbiXTgwxkp6LvyHSmbhVu0qmYZxESO-_61zgdFQbHOBg@mail.gmail.com>

On 04/03/2024 07:33, Bart Schaefer wrote:
> % ls Src/utom4te.cache config S
> Scripts/       Src/           StartupFiles/
>
> This occurred after using right-arrow to select Src from the menu.
> % ls <TAB>
> Then use interactive completion to fill in
> % ls autom4te.cache config
> Then add S and press TAB:
> % ls autom4te.cache config S<TAB>
> Then right arrow from Script to Src and end up with the mess above.
>
> Settings:
>    bindkey ^I menu-select
>    MENUMODE=interactive

Dammit, I wasn't aware of the 2023 follow-up thread you linked in the 
previous mail...

I'll look into it and on the the issue you just mentionned.

However, is it not another bug that the one that concerned me in the 
first place?
(Not that I wouldn't want to spend time on this one too :p)


So, trying your test case on the clean Arch repo's zsh package,
I noticed that if you don't press <TAB> on step 3., pressing the arrow 
will give you this:
% ls Src/

Is it really the expected behavior? Would it not be better if it left 
you with:
% ls autom4te.cache config Src/
?

I'm asking since without thinking or looking much into it, I can think 
of two possible solutions.


Also, back at my initial issue and my patch, I noticed I made an 
assumption that might be wrong about the expected behavior:

Marlon's test case from the 2021 thread was:

> % touch test{1,2}
> % : ; foobar
>      ^ 1. Type the above line in its entirety.
>        2. Place the cursor before the ;
>        3. Press Tab.
>        4. Press Enter.
> % : test1 bar
>      ^ Completion is written over existing buffer contents.

with my patch, he would end up with
% : test1 foobar

In that case, should the ';' still be present?
ie. % : test1; foobar



  reply	other threads:[~2024-03-04 11:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-04 16:30 Marlon Richert
2024-03-04  1:44 ` Samy Dulor
2024-03-04  2:05   ` Bart Schaefer
2024-03-04  6:33     ` Bart Schaefer
2024-03-04 11:30       ` Samy Dulor [this message]
2024-03-04 22:38         ` Bart Schaefer
     [not found] <8964126.CDJkKcVGEf.ref@phy-nordri>
2022-07-15 13:39 ` Andrea Manenti
2022-07-16 18:11   ` Bart Schaefer
2022-07-16 22:57     ` Bart Schaefer
     [not found]       ` <2844417.e9J7NaK4W3@phy-nordri>
2022-07-22 16:32         ` Bart Schaefer
2022-07-22 17:55           ` Bart Schaefer
2022-07-22 18:23             ` Bart Schaefer
2022-07-22 19:10               ` Andrea Manenti
2023-11-17  3:35     ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a90a759-2853-b6e1-8d9b-5824afbc8f47@orange.fr \
    --to=samy.dulor@orange.fr \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).