From: DragonK <dragonk@gmail.com>
To: zsh-workers@sunsite.dk
Subject: Buffer overflow in "!" handling?
Date: Wed, 25 Feb 2009 11:42:50 +0200 [thread overview]
Message-ID: <8fa12ca90902250142s171605bekd87885e3dbc5c4a6@mail.gmail.com> (raw)
Hello,
I've stumbled upon a buffer overflow in zsh 4.3.9 (and 4.3.6) related
to the handling of the "!" character in the command line (Linux).
It's triggerable by typing "!AAAAAAAAA...A" (lots of A's) at the zsh
prompt (works better if zsh is compiled with stack protection,
otherwise a lot of A's are needed :) ).
A quick look at the code indicates the problem to be in hist.c,
function histsubchar(), where buf[256] is getting overflowed (*ptr is
used to write to the buffer, but no check is made to see if ptr passed
the end of buf). I might be wrong though, I only took a couple of
minutes to look at the code.
next reply other threads:[~2009-02-25 9:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-25 9:42 DragonK [this message]
2009-02-25 10:26 ` Peter Stephenson
2009-02-25 11:39 ` DragonK
2009-02-25 11:42 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fa12ca90902250142s171605bekd87885e3dbc5c4a6@mail.gmail.com \
--to=dragonk@gmail.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).