From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: zsh-workers-return-43673-ml=inbox.vuxu.org@zsh.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 4e4a6d37 for ; Thu, 11 Oct 2018 09:51:44 +0000 (UTC) Received: (qmail 25632 invoked by alias); 11 Oct 2018 09:51:26 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43673 Received: (qmail 7000 invoked by uid 1010); 11 Oct 2018 09:51:26 -0000 X-Qmail-Scanner-Diagnostics: from park01.gkg.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(205.235.26.22):SA:0(-1.4/5.0):. Processed in 2.379793 secs); 11 Oct 2018 09:51:26 -0000 X-Envelope-From: SRS0=hs2J=MX=yahoo.co.uk=okiddle@bounces.park01.gkg.net X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | X-Virus-Scanned: by amavisd-new at gkg.net Authentication-Results: amavisd4.gkg.net (amavisd-new); dkim=pass (2048-bit key) header.d=yahoo.co.uk X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.uk; s=s2048; t=1539251124; bh=LFNZBbPXY6rKMk/BS8u2csNUbamyievx9CkrUOw8VUk=; h=From:References:To:Subject:Date:From:Subject; b=PX+IMd5C5xyWC7/XxNU9RNddEXuOcFuaC8e+rnfFwm5k9snqQo6R3D53kn1mnjsAg8FcOWsuFMQNRNk3omOspkxiL+KfE8unuw0NBu23sZl05Skda2SwbhoduIqXvG0KxenBSvo/zw+P6UK/MiB6ryUPeNx/7H2INx1JbSpszLTdu7xirR4AhEeSfFzGNDX8Vd+pr7+3No5UK37Li9QNN/Ni36AyBvwtmSSQAbRWXg4+sF4orPjT3s+ngiDMeB4oyqaU1jv/w0+v5owbGwJPBo7c/9ePERAFaduE9n4yiUONdwJD7YPHTcYRjS9g1E8fbww8PysttP5SBsfE6NqvXQ== X-YMail-OSG: YtwDAMkVM1kMljI3Sr25e63giD1yRKH3cbHebjQdF56riPkC_vQnwxJNDcBCDbt aA6l_gu2F7rxbyAwgfHpVth42a_Du0qBJbuSz9oGE9g9_qZNnwYGNq.Movy5wpaoGbJF8cD4VnB2 1XYR.YnP.a3KKWUFum6wvYEQCjUGzZktU_VCQ_kZOW9iJiHKEuwcvm2.8aNn4mycunn11glGk5Gu 2n5DN0NWv1idSg5bQoNqywvdT6ctCuMTxUsbr7JnVpuPZMJuFQDjEsMemXRe3pFMXft1b7xrYwRS QBxhj9RnLavlHznzkEaHuTgYq5C5XxaBBL.aoyu7kXTdXja.1SFahF6qRdYEEfekk4yb0qbRRJpP rb4mSEAs0zHA7GZYtpOXIpU3KU9bvRnKbsI20rdGrJzldpvXZCDew0RLiBD8kkO1vmUIsqc_HE3p yQT0R4NpMFYxVoP._M3Ro.dmPIf5mduE6tbNyNDH7XsG9j_8Epk2ESFkmZ0Dx8kRF8sAtruokXL3 3ZR2K5Lq5cwLk8tlTP2n88HROkxrOLKE2dgLR_kFf_6fjaWCImgJqf3ZvdOcaG4tewSF7gCuTGA9 AGlRaTcrAMOIIIcye_2Ndk9R2ccBbY8JG4lVzo4G3iDbSsTEUWVCnemPSLi1uvJLSqYPMdXqxr7D L68ZTZHnZqDCnZdk1FwXqn1S1gLAPPpV8d.AaRZk5j0f5v_lnK9SrVKjKzF40UPOJjfOLqMBHQZG EBY5jAAcKHuKCrUExfXLUx4nPkK06GidlnCEMitI8U2UEOu_89pIMd1fJmEFhZ_LPJJGmbPf_yK1 o1V3obNat9UCYXdmhnG9.1nkl1aa36nmkPMoMMEEeS1CmegZZfhFq0Ll3_t5bz4JleLJJzRNwKEX 98IKQunh02QLF8Ara12tewNMz4w8kyC9n5cOw4GUYgY8JaWtdLd1bKHJFFee5tWulwJACiCxwx6u NtVuwlul_4P7lqE9FM5c.lnhHNCebqN2QkSvgXbpTE2uewJSSPSqLdmo_.DyntCiWATweCLTWsTt V0iMg5rs0kT0VSA0VFi5N70jpr8PMywPuYA-- In-reply-to: <20181007133545.zzkrbc3ed6shnk3e@chaz.gmail.com> From: Oliver Kiddle References: <20180924210550.carijwjibarjivu4@chaz.gmail.com> <20181007133545.zzkrbc3ed6shnk3e@chaz.gmail.com> To: Zsh hackers list Subject: Re: [PATCH] [long] typeset doesn't report tied parameters (and related issues) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <90010.1539251122.1@hydra> Date: Thu, 11 Oct 2018 11:45:22 +0200 Message-ID: <90011-1539251122.433925@_kdU.FXyh.KLiu> On 7 Oct, Stephane Chazelas wrote: > +#define PM_NAMEDDIR (1<<31) /* has a corresponding nameddirtab entry */ On a 32-bit system, this now results in integer overflow compiler warnings. flags in struct hashnode is declared as being of type int. unsigned int might have been a better choice for a variable holding bit flags in the first place but struct hashnode is widely used so changing the type probably is not a matter of just changing the one line. With that in mind, should we change it straight to uint64_t and open up space for expansion? We don't have any existing uses of stdint.h types like uint64_t. I wouldn't blink at using them in other codebases but do we need to add any autoconf magic to preserve wide portability? Oliver